From e2e5c5102bf3d46cda322347a15a3490b4faf766 Mon Sep 17 00:00:00 2001 From: "Zach \"Phar\" Parks" Date: Tue, 5 Nov 2024 08:33:41 +0000 Subject: [PATCH] Rogue Legacy: Remove item/location id overlap rejection code. (#3893) * Rogue Legacy: Remove item/location id overlap rejection code. RL has been updated to support id overlaps. * Update __init__.py --------- Co-authored-by: NewSoupVi <57900059+NewSoupVi@users.noreply.github.com> --- worlds/rogue_legacy/__init__.py | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/worlds/rogue_legacy/__init__.py b/worlds/rogue_legacy/__init__.py index 290f4a60ac21..7ffdd459db48 100644 --- a/worlds/rogue_legacy/__init__.py +++ b/worlds/rogue_legacy/__init__.py @@ -46,30 +46,6 @@ def fill_slot_data(self) -> dict: return self.options.as_dict(*[name for name in self.options_dataclass.type_hints.keys()]) def generate_early(self): - location_ids_used_per_game = { - world.game: set(world.location_id_to_name) for world in self.multiworld.worlds.values() - } - item_ids_used_per_game = { - world.game: set(world.item_id_to_name) for world in self.multiworld.worlds.values() - } - overlapping_games = set() - - for id_lookup in (location_ids_used_per_game, item_ids_used_per_game): - for game_1, ids_1 in id_lookup.items(): - for game_2, ids_2 in id_lookup.items(): - if game_1 == game_2: - continue - - if ids_1 & ids_2: - overlapping_games.add(tuple(sorted([game_1, game_2]))) - - if overlapping_games: - raise RuntimeError( - "In this multiworld, there are games with overlapping item/location IDs.\n" - "The current Rogue Legacy does not support these and a fix is not currently planned.\n" - f"The overlapping games are: {overlapping_games}" - ) - # Check validation of names. additional_lady_names = len(self.options.additional_lady_names.value) additional_sir_names = len(self.options.additional_sir_names.value)