Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation interface filters don't work if a translated string is removed #256

Open
monitz87 opened this issue Mar 15, 2017 · 3 comments
Open

Comments

@monitz87
Copy link

When the extractor marks a native string as removed, it doesn't do so for any translations of said string. This causes a bug in the interface when using filters because the query that fetches all strings is filtering out the native (removed) string, but not the translations.

This means that when later attempting to match string.file with the filter it crashes because lone translations do not have a file attribute. I have worked around it by adding a function to my startup that marks translations as removed if their respective native string is also marked, but it shouldn't be too hard to fix the extractor to avoid this.

The error itself occurs in meteor-messageformat/packages/ui/lib/client.js, line 245, but the fix should be in the extractor code that marks strings as removed.

Cheers

@gadicc
Copy link
Owner

gadicc commented May 2, 2017

Hi again @monitz87, thanks for reporting this. You're absolutely right. I regret however that unless this bug receives more traction, I probably won't have a chance to get to it before working on the next version. Hope you agree with my priorities.

@monitz87
Copy link
Author

monitz87 commented May 2, 2017

Sure, I'm just doing my part by reporting. I understand that you have your priorities and it's perfectly ok. Maybe I'll get around to fixing it myself and submitting a PR when I find the time.

Cheers

@sbalmer
Copy link
Collaborator

sbalmer commented Oct 16, 2017

Presumably this is fixed now that f829954 is merged. It's an UI fix tough, as entries that lack a native translation are simply ignored.

@monitz87 can you check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants