You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the extractor marks a native string as removed, it doesn't do so for any translations of said string. This causes a bug in the interface when using filters because the query that fetches all strings is filtering out the native (removed) string, but not the translations.
This means that when later attempting to match string.file with the filter it crashes because lone translations do not have a file attribute. I have worked around it by adding a function to my startup that marks translations as removed if their respective native string is also marked, but it shouldn't be too hard to fix the extractor to avoid this.
The error itself occurs in meteor-messageformat/packages/ui/lib/client.js, line 245, but the fix should be in the extractor code that marks strings as removed.
Cheers
The text was updated successfully, but these errors were encountered:
Hi again @monitz87, thanks for reporting this. You're absolutely right. I regret however that unless this bug receives more traction, I probably won't have a chance to get to it before working on the next version. Hope you agree with my priorities.
Sure, I'm just doing my part by reporting. I understand that you have your priorities and it's perfectly ok. Maybe I'll get around to fixing it myself and submitting a PR when I find the time.
When the extractor marks a native string as removed, it doesn't do so for any translations of said string. This causes a bug in the interface when using filters because the query that fetches all strings is filtering out the native (removed) string, but not the translations.
This means that when later attempting to match string.file with the filter it crashes because lone translations do not have a file attribute. I have worked around it by adding a function to my startup that marks translations as removed if their respective native string is also marked, but it shouldn't be too hard to fix the extractor to avoid this.
The error itself occurs in
meteor-messageformat/packages/ui/lib/client.js
, line 245, but the fix should be in the extractor code that marks strings as removed.Cheers
The text was updated successfully, but these errors were encountered: