Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload the server #55

Open
clayne11 opened this issue Apr 27, 2016 · 1 comment
Open

Hot reload the server #55

clayne11 opened this issue Apr 27, 2016 · 1 comment
Milestone

Comments

@clayne11
Copy link
Contributor

clayne11 commented Apr 27, 2016

I love this package and the ability to hot reload components (and eventually styles!) on the client. It's saving me lots of development time.

That being said, every time I make a change to a shared file (which is ALL of my components to support SSR) it causes a full server reload and I can't interact with the server until the reload finishes, which for my app is around 30 seconds.

This got me thinking - is it possible to short-circuit the reload on the server and simply hot patch the server side as well?

@gadicc
Copy link
Owner

gadicc commented Apr 28, 2016

This is something I'd like to aim for in the long term. Two main problems I foresee:

  • We won't be able to replace the existing modules-runtime as easily. Will investigate other avenues to hack this but most likely will require putting a replacement modules-runtime in the app's packages dir.
  • Blocking the server reload... this would also be hard; might have to go back to our old way of tricking the bundler into thinking that nothing has changed... but then there's no fallback if we get something wrong (like how we just let the new bundle through on the client via HCP if HMR fails).

@gadicc gadicc added this to the Long-term milestone May 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants