spdlog failed to create daily log file at 23:59

[rjvrdhn]

I am trying to use spdlog to generate daily log at 23:59. Log entries happen inside mutex lock on separate thread (TimerThread). At 23:58 or 23:59 log file stops entries as expected, but does not create new log file until 4:27-4:30AM. My system time zone is set to UTC. Also seems like the thread that starts TimerThread gets locked. Please see attached code. What am I doing wrong?
Here is the TimerThread code I used: https://codereview.stackexchange.com/questions/127552/portable-periodic-one-shot-timer-thread-follow-up. To test if TimerThread is doing something funny to lockup, I have some code to test timer thread with rotating file sink, which keeps running even after 23:59 clock time with out any issues.

#include <iostream>
#include <stdlib.h>
#include <spdlog/sinks/daily_file_sink.h>
#include <spdlog/sinks/rotating_file_sink.h>
#include <TimerThread.h>
#include <time.h>
#include <chrono>
#include <sstream>
#include <iomanip>


typedef struct data {
    int someNumber;
    std::string somestring;
}DATA;

DATA updateThis;
std::mutex lockme;
DATA testDailyLog;
DATA testCustomLog;
std::mutex dailyLogLock;
std::mutex customLogLock;

//UTC timestamp
std::string GetTimeStampUTCStr()
{
    auto time = std::chrono::system_clock::to_time_t(
        std::chrono::system_clock::now());
        std::ostringstream ss;
        ss << std::put_time(gmtime(&time), "%FT%TZ");
    return ss.str();
}

// daily log test section
void logDailyLogData(std::shared_ptr<spdlog::logger> logger)
{
    dailyLogLock.lock();
    logger->info("{}: {}", GetTimeStampUTCStr(), testDailyLog.somestring);
    dailyLogLock.unlock();
}


void updateDailyLogData(){
    int num = rand()%300;
    while(1) {
        std::this_thread::sleep_for(std::chrono::milliseconds(num));
        dailyLogLock.lock();
        testDailyLog.somestring = "some number: " + std::to_string(num);
        testDailyLog.someNumber = num;
        dailyLogLock.unlock();
    }
}

void testDialyLogger() {
    auto logger = spdlog::daily_logger_mt("dailylog","dailylog.txt", 23,59,false, 5);
    logger->set_level(spdlog::level::debug);
    logger->flush_on(spdlog::level::debug);
    TimerThread *timer = new TimerThread();
    timer->addTimer(1000, 60000, std::bind(&logDailyLogData, logger));
    updateDailyLogData();
}
// test just timer thread

void timerThreadTestFunc(std::shared_ptr<spdlog::logger> logger){
    
    logger->info("{}", GetTimeStampUTCStr());
}

void testTimerThreadOnly(){
    auto logger = spdlog::rotating_logger_mt("timerOnlyLog","timertest.txt", 55555, 5, true);
    logger->set_level(spdlog::level::debug);
    logger->flush_on(spdlog::level::debug);
    TimerThread *timer = new TimerThread();
    timer->addTimer(1000, 60000, std::bind(&timerThreadTestFunc, logger));
}


int main(int, char**) {
    std::cout << "Hello, world!\n";
    /* initialize random seed: */
    srand (time(NULL));
    std::thread dailyLogThread(testDialyLogger);
    //std::thread customLogThread(testCustomLogger);
    std::thread timerTestThread(testTimerThreadOnly);
    //std::thread dailyLogNoLockThread(testTimerThreadDailyLogWithNoLock);

    dailyLogThread.join();
    //customLogThread.join();
    timerTestThread.join();
    //dailyLogNoLockThread.join();
    return 0;
}

• OS: Ubuntu 20.04
• Compiler GCC 9.3.0
• CXX_STANDARD set to C++14

[tt4g]

This problem already solved by #1895