Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Open Dissenter as new tab/window #11

Open
animegirl13 opened this issue Mar 2, 2019 · 7 comments
Open

Feature Request - Open Dissenter as new tab/window #11

animegirl13 opened this issue Mar 2, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@animegirl13
Copy link

Title is self explanatory but yeah. Would love if there was a button to open dissenter as a new tab or window

@mgabdev mgabdev added the enhancement New feature or request label Mar 2, 2019
@mgabdev
Copy link
Collaborator

mgabdev commented Mar 6, 2019

Thanks for the suggestion. For clarity, would you envision this feature working like:

  • A button is displayed on a page, upon click, a new tab/window opens
  • The Extension button (next to the url input in the browser), upon click, opens a new tab/window
  • Something else?

@danuker
Copy link

danuker commented Mar 6, 2019

Speaking for myself (since OP didn't respond yet), the reason I want this is because the browser popup is too easy to close. If I want to copy something from the page to quote, the popup closes, and the Dissenter page inside it is lost with my comment.

My particular problem can be solved better by #16 - a sidebar that does not close when I try to copy something would be ideal.

Strictly looking at this ticket, I can envision two scenarios useful to me:

Scenario A: Setting of where to open the comments

There is a preference/setting where I can choose what the Extension button (next to the URL) does, the options being:

  • Show a pop-up (as is now)
  • Open in a new page/tab/window (regular browser window like other pages)

Scenario B: "Pop-out" button

There is a "pop-out" button somewhere on the pop-up, which lets you make that pop-up into a regular page/tab/window. However scenario B might be a bit slower, since the browser has to load the comments page for the popup, and then for the regular page again.

@animegirl13
Copy link
Author

animegirl13 commented Mar 6, 2019

* A button is displayed on a page, upon click, a new tab/window opens

That was what I originally had in mind, however after reading @danuker post I believe his Scenario A would work out better.

@danuker
Copy link

danuker commented Mar 12, 2019

There is a workaround for scenario B, at least in Firefox: right-click the popup, then go to "This Frame" -> "Open Frame in New Tab".

@danuker
Copy link

danuker commented Mar 12, 2019

@animegirl13 : don't you think a sidebar (either browser-based or HTML-injected) would be even better?

@geeknik
Copy link

geeknik commented Mar 24, 2019

I'm all for tapping the extension button and getting the dissenter page open up in a new tab.

@DennisLoska
Copy link

DennisLoska commented Apr 2, 2019

@mgabdev Just inject some HTML to the current page e.g. <div id="root"></div> and render the whole app inside that div popup. That way you could make the window draggable, resizeable and also add some opacity to see some of the websites content. At least that's what I would do. Right now the extension feels clunky to work with, because the window is small, fixed and you have to scroll a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants