-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ges): import ges_metadata resource and doc #191
Merged
chengxiangdong
merged 1 commit into
g42cloud-terraform:main
from
Zhukun-Huawei:ges_branch
Dec 28, 2023
Merged
feat(ges): import ges_metadata resource and doc #191
chengxiangdong
merged 1 commit into
g42cloud-terraform:main
from
Zhukun-Huawei:ges_branch
Dec 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Dec 12, 2023
/lgtm |
github-ci-robot
added
the
LGTM
"Looks good to me", indicates that a PR is ready to be merged.
label
Dec 14, 2023
PR needs rebase. |
Zhukun-Huawei
force-pushed
the
ges_branch
branch
from
December 28, 2023 08:37
ef048d4
to
14c021d
Compare
github-ci-robot
removed
LGTM
"Looks good to me", indicates that a PR is ready to be merged.
needs-rebase
labels
Dec 28, 2023
g42cloud/provider.go
Outdated
Comment on lines
452
to
461
"g42cloud_identity_role_assignment": iam.ResourceIdentityGroupRoleAssignment(), | ||
"g42cloud_identity_user": iam.ResourceIdentityUser(), | ||
"g42cloud_identity_group": iam.ResourceIdentityGroup(), | ||
"g42cloud_identity_group_membership": iam.ResourceIdentityGroupMembership(), | ||
"g42cloud_identity_acl": iam.ResourceIdentityACL(), | ||
"g42cloud_identity_agency": iam.ResourceIAMAgencyV3(), | ||
"g42cloud_identity_project": iam.ResourceIdentityProject(), | ||
"g42cloud_identity_provider": iam.ResourceIdentityProvider(), | ||
"g42cloud_identity_provider_conversion": iam.ResourceIAMProviderConversion(), | ||
"g42cloud_identity_role": iam.ResourceIdentityRole(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that identity resources are introduced, please check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Zhukun-Huawei
force-pushed
the
ges_branch
branch
from
December 28, 2023 09:14
14c021d
to
3406346
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
transfer ges resource from HuaweiCloud to G42Cloud
Which issue this PR fixes:
import ges resource, unit tests and docs
Release note:
PR Checklist
Acceptance Steps Performed