Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ges): import ges_metadata resource and doc #191

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

Zhukun-Huawei
Copy link
Contributor

@Zhukun-Huawei Zhukun-Huawei commented Dec 12, 2023

What this PR does / why we need it:
transfer ges resource from HuaweiCloud to G42Cloud
Which issue this PR fixes:
import ges resource, unit tests and docs

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

=== RUN   TestAccGesMetadata_basic
=== PAUSE TestAccGesMetadata_basic
=== CONT  TestAccGesMetadata_basic
--- PASS: TestAccGesMetadata_basic (93.30s)
PASS

coverage: 11.4% of statements in ../../../../../terraform-provider-g42cloud/...

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 12, 2023
@Zippo-Wang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2023
@github-ci-robot
Copy link
Collaborator

PR needs rebase.

@github-ci-robot github-ci-robot removed LGTM "Looks good to me", indicates that a PR is ready to be merged. needs-rebase labels Dec 28, 2023
Comment on lines 452 to 461
"g42cloud_identity_role_assignment": iam.ResourceIdentityGroupRoleAssignment(),
"g42cloud_identity_user": iam.ResourceIdentityUser(),
"g42cloud_identity_group": iam.ResourceIdentityGroup(),
"g42cloud_identity_group_membership": iam.ResourceIdentityGroupMembership(),
"g42cloud_identity_acl": iam.ResourceIdentityACL(),
"g42cloud_identity_agency": iam.ResourceIAMAgencyV3(),
"g42cloud_identity_project": iam.ResourceIdentityProject(),
"g42cloud_identity_provider": iam.ResourceIdentityProvider(),
"g42cloud_identity_provider_conversion": iam.ResourceIAMProviderConversion(),
"g42cloud_identity_role": iam.ResourceIdentityRole(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that identity resources are introduced, please check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@chengxiangdong chengxiangdong merged commit 10b165b into g42cloud-terraform:main Dec 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants