feat(dcs): import dcs resource and add unit test and docs #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR needs rebase. |
Zhukun-Huawei
force-pushed
the
dcs_branch
branch
from
6cfc7cb
to
c8f9068
Compare
github-actions
bot
added
the
size/L
Zhukun-Huawei
force-pushed
the
dcs_branch
branch
from
c8f9068
to
20cb0d3
Compare
|
/lgtm |
github-ci-robot
added
the
LGTM
Zhukun-Huawei
force-pushed
the
dcs_branch
branch
from
20cb0d3
to
151abe9
Compare
github-actions
bot
added
size/XL
github-ci-robot
removed
the
LGTM
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
docs/data-sources/dcs_instances.md
Outdated
|
|
||
| * `maintain_end` - Indicates the time at which the maintenance time window ends. | ||
|
|
||
| * `charging_mode` - Indicates the charging mode of the cache instance. |
There was a problem hiding this comment.
This field is unnecessary, please remove it.
Zhukun-Huawei
force-pushed
the
dcs_branch
branch
from
151abe9
to
7ff7677
Compare
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
/lgtm |
github-ci-robot
added
the
LGTM
|
/approve |
github-ci-robot
approved these changes
Dec 28, 2023
github-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed