Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MPC): add DataSources to retrieve templates and template groups #153

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

Zippo-Wang
Copy link
Contributor

@Zippo-Wang Zippo-Wang commented Nov 17, 2023

What this PR does / why we need it:
import MPC resource, unit test and document

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed


### resource_g42cloud_mpc_transcoding_template

=== RUN   TestAccTranscodingTemplate_basic
=== PAUSE TestAccTranscodingTemplate_basic
=== CONT  TestAccTranscodingTemplate_basic
--- PASS: TestAccTranscodingTemplate_basic (43.98s)
PASS
coverage: 11.1% of statements in ../../../../../terraform-provider-g42cloud/...


=== RUN   TestAccTranscodingTemplate_basic2
=== PAUSE TestAccTranscodingTemplate_basic2
=== CONT  TestAccTranscodingTemplate_basic2
--- PASS: TestAccTranscodingTemplate_basic2 (23.58s)
PASS

coverage: 11.1% of statements in ../../../../../terraform-provider-g42cloud/...


=== RUN   TestAccTranscodingTemplate_basic3
=== PAUSE TestAccTranscodingTemplate_basic3
=== CONT  TestAccTranscodingTemplate_basic3
--- PASS: TestAccTranscodingTemplate_basic3 (23.71s)
PASS

coverage: 11.1% of statements in ../../../../../terraform-provider-g42cloud/...


=== RUN   TestAccTranscodingTemplate_basic4
=== PAUSE TestAccTranscodingTemplate_basic4
=== CONT  TestAccTranscodingTemplate_basic4
--- PASS: TestAccTranscodingTemplate_basic4 (22.46s)
PASS

coverage: 11.1% of statements in ../../../../../terraform-provider-g42cloud/...


=== RUN   TestAccTranscodingTemplate_basic5
=== PAUSE TestAccTranscodingTemplate_basic5
=== CONT  TestAccTranscodingTemplate_basic5
--- PASS: TestAccTranscodingTemplate_basic5 (23.02s)
PASS

coverage: 11.1% of statements in ../../../../../terraform-provider-g42cloud/...

‍```


### resource_g42cloud_mpc_transcoding_template_group


=== RUN   TestAccTranscodingTemplateGroup_basic
=== PAUSE TestAccTranscodingTemplateGroup_basic
=== CONT  TestAccTranscodingTemplateGroup_basic
--- PASS: TestAccTranscodingTemplateGroup_basic (48.44s)
PASS

coverage: 11.1% of statements in ../../../../../terraform-provider-g42cloud/...

=== RUN   TestAccTranscodingTemplateGroup_basic2
=== PAUSE TestAccTranscodingTemplateGroup_basic2
=== CONT  TestAccTranscodingTemplateGroup_basic2
--- PASS: TestAccTranscodingTemplateGroup_basic2 (48.84s)
PASS

coverage: 11.1% of statements in ../../../../../terraform-provider-g42cloud/...


=== RUN   TestAccTranscodingTemplateGroup_basic3
=== PAUSE TestAccTranscodingTemplateGroup_basic3
=== CONT  TestAccTranscodingTemplateGroup_basic3
--- PASS: TestAccTranscodingTemplateGroup_basic3 (25.88s)
PASS

coverage: 11.1% of statements in ../../../../../terraform-provider-g42cloud/...

‍```



@github-ci-robot
Copy link
Collaborator

PR needs rebase.

@chengxiangdong
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added LGTM "Looks good to me", indicates that a PR is ready to be merged. needs-rebase and removed needs-rebase labels Nov 29, 2023
@github-ci-robot github-ci-robot removed the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2023
@github-actions github-actions bot added the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2023
Copy link

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 30, 2023
@chengxiangdong
Copy link
Collaborator

/retitle feat(MPC): add DataSources to retrieve templates and template groups

@github-ci-robot github-ci-robot changed the title feat(MPC): import MPC resource, unit test and document feat(MPC): add DataSources to retrieve templates and template groups Dec 1, 2023
@github-ci-robot github-ci-robot removed the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@chengxiangdong
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2023
@chengxiangdong
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2023
@github-ci-robot github-ci-robot merged commit 4647525 into g42cloud-terraform:main Dec 28, 2023
6 checks passed
@Zippo-Wang Zippo-Wang deleted the migrate_MPC branch December 28, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants