From 012648bb89e8bce83238b31a4d2f9df151e01b24 Mon Sep 17 00:00:00 2001
From: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com>
Date: Tue, 7 Nov 2023 14:52:03 +0800
Subject: [PATCH] chore(sync): fix sync to use try catch (#3)

#### What this PR does / why we need it:

As per title.
---
 .github/PULL_REQUEST_TEMPLATE.md              | 11 -----------
 workspace/sync-trustwallet-assets/src/sync.ts | 19 +++++++++++++------
 2 files changed, 13 insertions(+), 17 deletions(-)

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index e11332821..b9534cfb8 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,14 +1,3 @@
-<!--  Thanks for sending a pull request! -->
-
 #### What this PR does / why we need it:
 
 #### Which issue(s) will this PR fix?:
-
-<!--
-(Optional) Automatically closes linked issue when PR is merged.
-Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
--->
-
-Fixes #
-
-#### Additional comments?:
diff --git a/workspace/sync-trustwallet-assets/src/sync.ts b/workspace/sync-trustwallet-assets/src/sync.ts
index 6fcc59362..d77241ebb 100644
--- a/workspace/sync-trustwallet-assets/src/sync.ts
+++ b/workspace/sync-trustwallet-assets/src/sync.ts
@@ -44,15 +44,15 @@ export abstract class Sync {
 
   async shouldWrite(dir: string, info: Partial<Info>): Promise<boolean> {
     // Make sure logo.png and info.json exists
-    const fromLogoStats = await stat(`${this.from}/${dir}/logo.png`);
-    const fromInfoStats = await stat(`${this.from}/${dir}/info.json`);
-    if (!fromLogoStats.isFile() || !fromInfoStats.isFile()) return false;
+    const hasFromLogo = await hasFile(`${this.from}/${dir}/logo.png`);
+    const hasFromInfo = await hasFile(`${this.from}/${dir}/info.json`);
+    if (!hasFromLogo || !hasFromInfo) return false;
 
     // If README.md and logo.png do not exist on the other side, write it
     const namespace = this.getNamespace(info);
-    const toLogoStats = await stat(`${this.to}/${namespace}/logo.png`);
-    const toReadmeStats = await stat(`${this.to}/${namespace}/README.md`);
-    if (!toLogoStats.isFile() || !toReadmeStats.isFile()) return true;
+    const hasToLogo = await hasFile(`${this.to}/${namespace}/logo.png`);
+    const hasToReadme = await hasFile(`${this.to}/${namespace}/README.md`);
+    if (!hasToLogo || !hasToReadme) return true;
 
     // Otherwise, allow overwriting if the author is Frontmatter Bot
     const name = await getAuthorName(`${this.to}/${namespace}/README.md`);
@@ -80,6 +80,13 @@ export abstract class Sync {
   }
 }
 
+function hasFile(filepath: string): Promise<boolean> {
+  return stat(filepath).then(
+    () => true,
+    () => false,
+  );
+}
+
 export class Eip155Sync extends Sync {
   async write(dir: string, info: Partial<Info>): Promise<void> {
     const namespace = this.getNamespace(info);