Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the initialSongIndex before further processing the round #283

Open
fusion2004 opened this issue Jan 18, 2021 · 0 comments
Open

Check the initialSongIndex before further processing the round #283

fusion2004 opened this issue Jan 18, 2021 · 0 comments

Comments

@fusion2004
Copy link
Owner

Right now, if you specify an invalid initialSongIndex, you don't get a notification until we download, transcode, generate announcers, play the stream intro and get ready to play the first track. That's a long while to wait and a lot of unnecessary work for a validation error.

We should move the check to as early as possible, just after fetching and reconciliation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant