Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Login with Microsoft ID #64

Open
JesseRWeigel opened this issue Jan 22, 2018 · 3 comments
Open

Implement Login with Microsoft ID #64

JesseRWeigel opened this issue Jan 22, 2018 · 3 comments

Comments

@JesseRWeigel
Copy link
Contributor

Can we implement something like this? https://blog.talentica.com/2017/06/23/implement-microsoft-login-in-a-react-js-app/

We would need some way to use a whitelist and only accept @franciscan.edu addresses.

@pantharshit00 since you created the login system, I would like your opinion on this please.

@pantharshit00
Copy link
Contributor

We should use passport js with microsoft as we also need to secure our graphql API that is being routed through our servers. I dont know but I guess making authentication client side we will not be able to protect our WP which make authentication useless. I am going to implement this using passport js.

@pantharshit00
Copy link
Contributor

Also we have cookie based auth already set in react so no need of writing any more code other than chaging email form to sign in with microsoft

@pantharshit00
Copy link
Contributor

implemented in #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants