Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Names can cause broken links #7

Open
JakeGinnivan opened this issue Oct 29, 2012 · 2 comments
Open

Tag Names can cause broken links #7

JakeGinnivan opened this issue Oct 29, 2012 · 2 comments

Comments

@JakeGinnivan
Copy link
Member

From @tim Hamilton

A good example of this is using C# as a tag. When the tag hyperlink is defined it drops the "#" causing the link to look like: "/tagged/c"
This returns no Entries when there is entries with the tag on it.

Suggest that when a tag is stored it contains a slug field. A unique HTTP link compatible value. It would be this value that would be placed in the tags link.

Example: Display Name: C# Slug: csharp

User Clicks on tag C# link that is passed is "/tagged/csharp"

This would allow user to specify special characters in their tags ie: F#, C#, C++

Keep up the great work MIT560

@tim
Copy link

tim commented Oct 29, 2012

@JakeGinnivan Not the Tim you're looking for :)

Good idea though. Alternatively you could escape the tag value in the URI, e.g. "/tagged/C%23". Not as pretty, but then you wouldn't need to add a slug field.

@JakeGinnivan
Copy link
Member Author

Sorry about that! Moving issues from bitbucket over to here :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants