Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull "readFile" util and the "uploadFile" test helper as it's own package. #167

Open
webark opened this issue Jun 23, 2017 · 1 comment
Open

Comments

@webark
Copy link

webark commented Jun 23, 2017

Ever thought about pulling just these two out into it's own package? I needed to create a custom file input, and the project as a whole didn't completely fit my needs, but these two things is exactly what I needed.

@jelhan
Copy link
Contributor

jelhan commented Jun 29, 2017

I'm not quite sure if both will fit into one package. But pulling out uploadFile test helper might make sense since other projects like yours or ember-uploader need similar test helpers. Also formData test helper might fit into such a package. If we do so, we should rename uploadFile test helper to inputFile or something similar cause it only triggers a change event on an input file value. It's totally up to application if this fires an upload action or something else. I could also add similar ember-page-object helpers to such a package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants