Query hydrate: update_original_relation only for relations concerned #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WanWizard
added a commit
that referenced
this pull request
Jan 27, 2014
…ions Query hydrate: update_original_relation only for relations concerned
WanWizard
added a commit
that referenced
this pull request
Jul 13, 2014
commit e8457ba Author: WanWizard <[email protected]> Date: Fri Jun 27 22:57:51 2014 +0200 fixed broken DB as_object() method; closes #334 commit d841283 Merge: 5eafadf f2a03f7 Author: Steve "Uru" West <[email protected]> Date: Wed Jun 4 11:19:36 2014 +0100 Merge pull request #350 from MacTwister/1.8/develop Passing model properties to is_changed method. commit f2a03f7 Author: Julian G <[email protected]> Date: Wed Jun 4 11:45:34 2014 +0200 Passing model properties to is_changed method. Passing model properties stops is_changed searching the relations by default which is already handled by the observer relation property if required by the model. Signed-off-by: Julian G <[email protected]> commit 5eafadf Merge: 9f9812c eff6b57 Author: Steve "Uru" West <[email protected]> Date: Tue Jun 3 19:51:50 2014 +0100 Merge pull request #349 from propcom/no-change-no-complain Don't complain about changing PK if it's not actually changing commit eff6b57 Author: Alastair McGowan-Douglas <[email protected]> Date: Tue Jun 3 17:23:27 2014 +0100 Don't complain about changing PK if it's not actually changing commit 9f9812c Author: WanWizard <[email protected]> Date: Mon May 12 17:42:55 2014 +0200 fixed incorrect processing of DB_Expr objects in select(); closes commit 4fe2f6d Merge: a709e3f 4cc3a4a Author: Harro Verton <[email protected]> Date: Sun May 11 20:45:02 2014 +0200 Merge pull request #344 from sagikazarmark/patch-1 Update slug.php commit 4cc3a4a Author: Márk Sági-Kazár <[email protected]> Date: Fri May 9 09:45:30 2014 +0200 Update slug.php Bad logical operator commit a709e3f Merge: 21575d7 91e9cad Author: Steve "Uru" West <[email protected]> Date: Sat May 3 23:22:58 2014 +0100 Merge pull request #343 from TamasBarta/1.8/develop Correcting typo in slug observer commit 91e9cad Author: Barta Tamás <[email protected]> Date: Sun May 4 00:19:13 2014 +0200 Correcting typo in slug observer commit 21575d7 Author: WanWizard <[email protected]> Date: Sun Apr 27 20:38:14 2014 +0200 added internal sanitation method to allow selective sanitation by overloading the method in your model and checking the $field value commit 449803a Merge: 72dc959 c553687 Author: Harro Verton <[email protected]> Date: Thu Apr 24 22:57:55 2014 +0200 Merge pull request #336 from sagikazarmark/1.8/develop Observer Slug manually assigned property commit 72dc959 Author: WanWizard <[email protected]> Date: Wed Apr 16 23:43:15 2014 +0200 add support for select('*') commit bc31c19 Author: WanWizard <[email protected]> Date: Wed Apr 16 23:32:12 2014 +0200 expirimental support for DB::expr() in ORM selects using syntax ->select(array(DB::expr("count(*)"), "columnaliasname")-> commit c7bd709 Author: WanWizard <[email protected]> Date: Wed Apr 16 23:30:18 2014 +0200 options for observers are always defined as an array commit c553687 Author: Sági-Kazár Márk <[email protected]> Date: Thu Apr 10 14:58:25 2014 +0200 Uniqueness and overwrite can now live with each other commit 8ff711b Author: Sági-Kazár Márk <[email protected]> Date: Thu Apr 10 14:50:20 2014 +0200 Fixed indentation commit f8792d7 Author: WanWizard <[email protected]> Date: Tue Apr 8 21:53:40 2014 +0200 on new objects, validation should run on all fields commit aeab0c5 Merge: c04496d 9c66ea7 Author: Harro Verton <[email protected]> Date: Sat Mar 22 19:44:36 2014 +0100 Merge pull request #342 from mikepmtl/patch-4 Update slug.php Observer. Uniqueness as option commit 9c66ea7 Author: mikepmtl <[email protected]> Date: Sat Mar 22 13:54:57 2014 -0400 Slug uniqueness as option commit 3c09630 Author: mikepmtl <[email protected]> Date: Sat Mar 22 10:15:52 2014 -0400 Update slug.php Observer. Uniqueness as option I use slugs very often simply to give the end use a better description of the URL and for SEO. Ex. "http://server.com/doc/281/communications/about/about-the- communications-department/" In a case like this I would prefer not to have uniqueness in the slug as I only require the ID (281) and I dislike slugs with numbers in them (about, about-1, about-2) since many "departments" in this case will have an "About" page. commit c04496d Author: WanWizard <[email protected]> Date: Wed Mar 5 12:55:21 2014 +0100 check both type and data_type to determine if loose typing is needed. Closes #339 commit a14c582 Merge: dd7ad22 bde4425 Author: Harro Verton <[email protected]> Date: Thu Feb 6 08:34:07 2014 +0100 Merge pull request #335 from sagikazarmark/1.8/develop Fixed separator in Observer Slug commit bde4425 Author: Sági-Kazár Márk <[email protected]> Date: Thu Feb 6 01:58:40 2014 +0100 Variable typo commit 6629d64 Author: Sági-Kazár Márk <[email protected]> Date: Thu Feb 6 01:51:52 2014 +0100 Fixed separator in Observer Slug commit dd7ad22 Merge: 58033db e83f6e9 Author: Harro Verton <[email protected]> Date: Mon Jan 27 08:45:06 2014 -0800 Merge pull request #328 from propcom/bugfix-original-relation-blank- ids Only update original relations with imploded PKs of not new objects commit 58033db Author: WanWizard <[email protected]> Date: Mon Jan 27 17:41:34 2014 +0100 revert PR #328 commit f4d7d4a Author: WanWizard <[email protected]> Date: Mon Jan 27 17:25:18 2014 +0100 make sure $frozen has a value commit fcbf763 Author: WanWizard <[email protected]> Date: Mon Jan 27 17:22:02 2014 +0100 do not cache the new object if we already have on (but it's frozen) commit c025511 Merge: f462c55 d79236a Author: Harro Verton <[email protected]> Date: Mon Jan 27 08:20:05 2014 -0800 Merge pull request #312 from felixgilles/bugfix_update_original_relations Query hydrate: update_original_relation only for relations concerned commit f462c55 Merge: 70ce541 928b607 Author: Harro Verton <[email protected]> Date: Mon Jan 27 08:19:57 2014 -0800 Merge pull request #333 from propcom/bugfix-frozen-hydration Don't use a frozen object from cache when hydrating commit e83f6e9 Author: Andrew Wheal <[email protected]> Date: Thu Dec 12 10:38:38 2013 +0000 extra checking on updating original relations commit c646935 Author: Andrew Wheal <[email protected]> Date: Mon Dec 9 11:33:03 2013 +0000 Only update original relations with imploded PKs of not new objects Signed-off-by: Andrew Wheal <[email protected]> commit 70ce541 Merge: 1ea1a1d e1dc87f Author: Harro Verton <[email protected]> Date: Fri Jan 17 02:06:58 2014 -0800 Merge pull request #329 from sagikazarmark/1.8/develop EAV properties added to to_array commit e1dc87f Author: Sági-Kazár Márk <[email protected]> Date: Fri Jan 17 11:04:33 2014 +0100 Check first whether $eav is true commit d7c5486 Author: Sági-Kazár Márk <[email protected]> Date: Fri Jan 17 11:03:40 2014 +0100 Fixed typo commit 928b607 Author: Andrew Wheal <[email protected]> Date: Wed Jan 15 10:46:50 2014 +0000 dont use a frozen object from cache when hydrating commit 1ea1a1d Author: WanWizard <[email protected]> Date: Sat Jan 11 20:27:33 2014 +0100 fixed passing custom data to a model constructor; fixed as_object() instantiations not cached thanks for @keigoi for spotting the custom data issue (see #332) commit 9355284 Author: Steve "uru" West <[email protected]> Date: Sat Jan 11 12:28:56 2014 +0000 Makes Soft_Delete::purge() actually delete models commit 9e15948 Author: WanWizard <[email protected]> Date: Fri Dec 27 13:07:50 2013 +0100 bumped the copyright to 2014 commit bf52bf6 Author: Sági-Kazár Márk <[email protected]> Date: Fri Dec 13 14:20:21 2013 +0100 Relation filtered, properties merged to array commit fbe8232 Author: Sági-Kazár Márk <[email protected]> Date: Fri Dec 13 13:35:38 2013 +0100 Introduced third parameter commit 8684c55 Author: Sági-Kazár Márk <[email protected]> Date: Fri Dec 13 12:28:34 2013 +0100 EAV processing is merged with EAV container check commit 4b8fc77 Author: Sági-Kazár Márk <[email protected]> Date: Fri Dec 13 12:07:31 2013 +0100 EAV properties are loaded in the correct order, property is a reference to the original relation array commit 7fe00c2 Author: Sági-Kazár Márk <[email protected]> Date: Mon Dec 9 16:46:51 2013 +0100 EAV properties added to to_array commit 381b811 Author: WanWizard <[email protected]> Date: Thu Dec 12 23:43:04 2013 +0100 remove static from method definitions commit ca9aeab Author: WanWizard <[email protected]> Date: Thu Dec 12 23:10:24 2013 +0100 make sure the before_save observer is called before checking the diff; closes #330 commit e3d2324 Author: WanWizard <[email protected]> Date: Thu Dec 12 23:09:51 2013 +0100 added methods to enable/disable defined observer events. related commit 235cf01 Merge: 03727af f62d64e Author: Harro Verton <[email protected]> Date: Thu Dec 12 12:16:57 2013 -0800 Merge pull request #331 from SlKelevro/fix-relations-connection- usage fixed many-to-many relation not using write connection commit f62d64e Author: slevin <[email protected]> Date: Thu Dec 12 16:05:55 2013 +0200 fixed many-to-many relation not using write connection commit 03727af Author: WanWizard <[email protected]> Date: Thu Dec 12 10:58:42 2013 +0100 permanent fix for e8a3ad0 commit e8a3ad0 Author: WanWizard <[email protected]> Date: Wed Dec 11 20:19:39 2013 +0100 do not attempt to clean relations commit c74e3ad Merge: 0f2dd15 3ab2a12 Author: Steve "Uru" West <[email protected]> Date: Thu Dec 5 03:34:17 2013 -0800 Merge pull request #326 from sagikazarmark/1.8/develop 1.8/develop commit 3ab2a12 Author: Sági-Kazár Márk <[email protected]> Date: Wed Dec 4 19:20:47 2013 +0100 Added id only primary key check to query condition commit 4240312 Author: Sági-Kazár Márk <[email protected]> Date: Wed Dec 4 18:53:17 2013 +0100 Temporal query add condition only if primary_key check is enabled commit 0f2dd15 Merge: 1efbd41 0452103 Author: Steve "Uru" West <[email protected]> Date: Sun Dec 1 14:22:04 2013 -0800 Merge pull request #325 from sagikazarmark/1.8/develop Temporal Model probable query fix commit 0452103 Author: Sági-Kazár Márk <[email protected]> Date: Sun Dec 1 23:16:51 2013 +0100 Temporal Model query condition added commit efba025 Author: Sági-Kazár Márk <[email protected]> Date: Sat Nov 30 20:19:41 2013 +0100 Removed trailing tabulator commit d79236a Merge: 397e81f 3a2b3b4 Author: Gilles FELIX <[email protected]> Date: Thu Oct 17 17:20:07 2013 +0200 Merge branch '1.8/develop' into bugfix_update_original_relations commit 397e81f Author: Gilles FELIX <[email protected]> Date: Wed Oct 2 15:50:52 2013 +0200 Query hydrate: update_original_relation only for relations concerned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reopen of PR #305, closed when the branch 1.7/develop has been deleted.
This PR not solves the #293 issue, but it prevents cases when problem does not arise (relation have not be fetched).