You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was wondering if it makes sense to add an action to run the benchmark for each pull-request, so we can identify if we want or not to merge the change (if it doesn't turn the solution into something so bad, what do you think?
Idea:
We run the action to test if everthing still working
We run the benchmark/index.ts file and grab all info and send as a comment on the PR, then we can easly understand if make sense or not to merge
The text was updated successfully, but these errors were encountered:
Benchmarks do need a little touchup. Some time should be taken to get the output more reliably and probably add other validation lib test suites to see how we compare to them
Question
I was wondering if it makes sense to add an action to run the benchmark for each pull-request, so we can identify if we want or not to merge the change (if it doesn't turn the solution into something so bad, what do you think?
Idea:
benchmark/index.ts
file and grab all info and send as a comment on the PR, then we can easly understand if make sense or not to mergeThe text was updated successfully, but these errors were encountered: