-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests #97
Comments
First, thanks for pulling these out into issues for discussion, I appreciate your diligence.
Good point... I've been sitting on some of these changes for a while, and it has taken a bit more effort to wrap them up than I thought it would, but I was planning to ping that issue once I had something for others to look at.
The most recent issue is that certain flaky tests failed in CI on Windows with python 3.10, but passed after two retries.
Definitely, and the changes I have been planning to submit include using When I prepare to submit those changes, I'll try to ping back here if I notice any particularly remarkable issues. |
I'm really looking forward to this. |
It seems tests are now pretty reliable, since the following PRs were merged:
Let's reopen a new issue in case we run into issues in the future. |
from #96
@brl0 that would be great. Maybe we could coordinate with fsspec/filesystem_spec#651 ?
Did you run into specific issues when running the current test suite?
Should we add some test order randomization to reveal issues regarding isolation?
The text was updated successfully, but these errors were encountered: