zip tests error in Debian build

[eamanu]

Hi!,

I'm building the latest version 2024.9.0, but I have two tests that are failing but I cannot figure out the issue.

The tests are:

FAILED fsspec/implementations/tests/test_zip.py::test_find_returns_expected_result_detail_true - AssertionError: assert {'CRC': 39643...nt': b'', ...} == {'CRC': 39643...nt': b'', ...}
FAILED fsspec/implementations/tests/test_zip.py::test_find_returns_expected_result_detail_true_include_dirs - AssertionError: assert {'CRC': 39643...nt': b'', ...} == {'CRC': 39643...nt': b'', ...}

And this is the assertion error:

result = {'dir1': {'CRC': 0, '_compresslevel': None, '_end_offset': 35, '_raw_time': 23816, ...}, 'dir2': {'CRC': 0, '_compress...2startwithsamename.txt': {'CRC': 1089626562, '_compresslevel': None, '_end_offset': 260, '_raw_time': 23816, ...}, ...}
expected_result = {'dir1': {'CRC': 0, '_compresslevel': None, '_end_offset': 35, '_raw_time': 22220, ...}, 'dir2': {'CRC': 0, '_compress...2220, ...}, 'file1.txt': {'CRC': 3964322768, '_compresslevel': None, '_end_offset': 193, '_raw_time': 22220, ...}, ...}

    def _assert_all_except_context_dependent_variables(result, expected_result):
        for path in expected_result.keys():
            assert result[path]
            result_without_date_time = result[path].copy()
            result_without_date_time.pop("date_time")
            result_without_date_time.pop("_raw_time")
            result_without_date_time.pop("external_attr")
            result_without_date_time.pop("create_system")
    
            expected_result_without_date_time = expected_result[path].copy()
            expected_result_without_date_time.pop("date_time")
            expected_result_without_date_time.pop("_raw_time")
            expected_result_without_date_time.pop("external_attr")
            expected_result_without_date_time.pop("create_system")
>           assert result_without_date_time == expected_result_without_date_time
E           AssertionError: assert {'CRC': 39643...nt': b'', ...} == {'CRC': 39643...nt': b'', ...}
E             
E             Omitting 18 identical items, use -vv to show
E             Differing items:
E             {'_end_offset': 124} != {'_end_offset': 193}
E             {'header_offset': 70} != {'header_offset': 139}
E             Use -v to get more diff

fsspec/implementations/tests/test_zip.py:178: AssertionError

Any clue? Thank you very much!

[QuLogic]

This is also failing for me in the Fedora package.

[QuLogic]

Also, my (newly-opened) PRs also fail with the same errors.

[martindurant]

Fix merged. You'll be wanting a release for the sake of packaging?

[eamanu]

@martindurant just to confirm, this is the fix?

[martindurant]

#1691 ( dc4f5a9 ) is the one, but #1689 (your link) is also relevant to ZIPs