Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes needed for HA integration #73

Open
torbennehmer opened this issue Apr 28, 2023 · 2 comments · May be fixed by #74
Open

Various fixes needed for HA integration #73

torbennehmer opened this issue Apr 28, 2023 · 2 comments · May be fixed by #74
Labels
bug

Comments

@torbennehmer
Copy link
Contributor

I did a few fixes for my HA integration of E3DC RSCP:

  • S10E Serial number detection did not work, a missing elif masked the corresponding check
  • A few exported classes were missing (notably SendError for error detection)
  • Calls to set_power_save and set_weather_regulated_charge were not correctly parsing the results from E3DC. (Did some code streamlining to those functions on the way)

PR follows in a minute.
@torbennehmer torbennehmer linked a pull request Apr 28, 2023 that will close this issue
Open
@vchrisb vchrisb added the bug label Apr 30, 2023
@torbennehmer
Copy link
Contributor Author

Partly fixed by #75

@torbennehmer torbennehmer mentioned this issue May 16, 2023
Closed
@torbennehmer
Copy link
Contributor Author

@vchrisb I've got a suggestion: While we figure out, what's up with set_weather_regulated_charge on my end: Could we do a release of the fixes in #75? I'd need the Serial Number detection and the missing exceptions for further work on my integration. With Home Assistant, the pye3dc dependency ist automatically loaded from PIP, so I cannot inject some patched version until this resolved even if I'd like to.
It would be really great, if this would be officially available :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

S10 fixes torbennehmer/python-e3dc
2 participants
@torbennehmer @vchrisb