Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AST validation: syntax description for Tables is wrong #30

Open
stepelu opened this issue Nov 15, 2015 · 2 comments
Open

AST validation: syntax description for Tables is wrong #30

stepelu opened this issue Nov 15, 2015 · 2 comments

Comments

@stepelu
Copy link
Contributor

stepelu commented Nov 15, 2015

According to ast-validate.lua, Tables are expected to be described in terms of the array_entries, hash_keys and hash_values properties.

However, lua-ast.lua generates Tables as with a single keyvals property which is essentially a list of pairs.

As such the validation of AST trees containing Tables is currently failing.

@franko
Copy link
Owner

franko commented Nov 16, 2015

Hi Stefano,

of course this need to be fixed. The validator for the table was broken when I merged some proposition of @gnois. We forgot to update the ast-validate stuff.

@stepelu
Copy link
Contributor Author

stepelu commented Nov 20, 2015

I am not sure it can be fixed without updating the various check functions, do you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants