Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in "Rolling your own crypto AES" #12

Open
litchipi opened this issue Nov 1, 2024 · 1 comment
Open

Error in "Rolling your own crypto AES" #12

litchipi opened this issue Nov 1, 2024 · 1 comment

Comments

@litchipi
Copy link
Contributor

litchipi commented Nov 1, 2024

First of all, thanks for the awesome article, didn't go through your entire blog yet, but it's definitely on my list ;-)

In line https://github.com/francisrstokes/githublog/blob/main/2022/6/15/rolling-your-own-crypto-aes.md?plain=1#L219 the result is 46 in base 10, not 0x46

@francisrstokes
Copy link
Owner

Thanks for pointing that out, and for taking a close read 😉
If you're up for it, send a PR with the fix and I'll happily merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants