New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make `fire build` and `fire setup` more reliable by moving the theme build to the end. #65

Open

dalin- opened this issue Dec 5, 2024 · 0 comments · May be fixed by #66

Contributor

dalin- commented Dec 5, 2024

I think builds are most likely to fail on the front-end. But due to the order of commands:

fire/src/Robo/Plugin/Commands/LocalBuildCommand.php

Line 24 in 58e4c8b

    
           public function localBuild(ConsoleIO $io, $opts = ['no-db-import' => FALSE, 'no-db-download' => FALSE, 'get-files|f' => FALSE]) {

this means that if the theme build fails, you won't even have a working local install (unthemed).

I suggest that we change the order of the commands.

dalin- linked a pull request

that will close this issue

Move theme build to the end since it's least likely to succeed. #66

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment