Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm: CI LUKS encryption #768

Merged
merged 2 commits into from
Nov 7, 2024
Merged

rm: CI LUKS encryption #768

merged 2 commits into from
Nov 7, 2024

Conversation

ldts
Copy link
Contributor

@ldts ldts commented Nov 5, 2024

Following foundriesio/meta-lmp#1530, we now allow users to define their own passphrases for CI LUKS encryption.

PR Template and Checklist

Please complete as much as possible to speed up the reviewing process.

Readiness and adding reviewers as appropriate is required.

All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Following foundriesio/meta-lmp#1530, we now
allow users to define their own passphrases for CI LUKS encryption.

Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>
@doanac
Copy link
Member

doanac commented Nov 5, 2024

Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a one suggestions with minor changes. Otherwise it LGTM.

source/reference-manual/linux/linux-disk-encryption.rst Outdated Show resolved Hide resolved
@doanac
Copy link
Member

doanac commented Nov 5, 2024

Copy link
Member

@vanmaegima vanmaegima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ldts
Copy link
Contributor Author

ldts commented Nov 7, 2024

@kprosise jfyi

@kprosise kprosise merged commit bce6725 into foundriesio:main Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants