-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rm: CI LUKS encryption #768
Conversation
Following foundriesio/meta-lmp#1530, we now allow users to define their own passphrases for CI LUKS encryption. Signed-off-by: Jorge Ramirez-Ortiz <[email protected]>
Docs for 25f3ada are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2793/docs/artifacts/html/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a one suggestions with minor changes. Otherwise it LGTM.
Co-authored-by: Katrina Prosise <[email protected]>
Docs for de0dd54 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2795/docs/artifacts/html/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@kprosise jfyi |
Following foundriesio/meta-lmp#1530, we now allow users to define their own passphrases for CI LUKS encryption.
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Overview
Why merge this PR? What does it solve?
Checklist
make linkcheck
.-s, --signoff
).-S, --gpg-sign
).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.