Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlook fowarded messages add line breaks after every row #308

Closed
getglad opened this issue Mar 30, 2016 · 5 comments
Closed

Outlook fowarded messages add line breaks after every row #308

getglad opened this issue Mar 30, 2016 · 5 comments

Comments

@getglad
Copy link

getglad commented Mar 30, 2016

Using just a basic template like so:

<container>
 <row>
    <columns large="4">
      abc
    </columns>
    <columns large="4">
      def
    </columns>
    <columns large="4">
      ghi
    </columns>
  </row>
  <row>
    <columns>
      123
    </columns>
    <columns>
      456
    </columns>
    <columns>
      789
    </columns>
  </row>
<container>

This produces fine in Outlook on the first send, but Outlook is added a paragraph element between every table. This is no effect on the layout/appearance because the display is set to none.

Content Added by Outlook in Original Message:
<P class=MsoNormal style="LINE-HEIGHT: 14.25pt"><SPAN style='FONT-FAMILY: "Helvetica",sans-serif; COLOR: #0a0a0a; **DISPLAY: none**'><?xml:namespace prefix = "o" ns = "urn:schemas-microsoft-com:office:office" /><o:p>&nbsp;</o:p></SPAN></P>

If the message if forwarded, Outlook is changing each paragraph line between every table.

Forwarded Message:
<P class=MsoNormal style="LINE-HEIGHT: 14.25pt"><SPAN style='FONT-FAMILY: "Helvetica","sans-serif"; COLOR: #0a0a0a'><?xml:namespace prefix = "o" ns = "urn:schemas-microsoft-com:office:office" /><o:p>&nbsp;</o:p></SPAN></P>

It is dropping the DISPLAY: none. This causes the spacing to expand in any forwarded message.

This is true in Outlook 2010 and 2013.

Am I using Inky correctly? Is there any known hack to get around this problem?

Other than this issue - Inky + foundation for emails is amazing.

@Xerxes-J
Copy link

TBH, forwarding emails will always break your design/layout. I've always struggled in getting it work properly.

@rafibomb
Copy link
Member

I'm not sure how the framework can solve this. Any ideas are definitely welcome!

@rafibomb
Copy link
Member

@getglad
Copy link
Author

getglad commented Apr 1, 2016

Yeah I'll be working on this off and on, so if you find something I'd be all ears. I have added a custom component to my local Inky, so happy to try pretty much anything.

It seems like what is really needed is just the ability to add an additional <tr>, rather than have every <row>...</row> add an additional <table>. Maybe there is a cross-client issue that makes that nonviable, but it seems like something worth trying to me.

Seeing that this is really more of an Inky issue, I can move myself over there if that's more appropriate.

@getglad
Copy link
Author

getglad commented Apr 13, 2016

To close the loop on this, I have made a PR for Foundation to update SCSS and for Inky to implement the additional components.
Foundation: #348
Inky: foundation/inky#34

@getglad getglad closed this as completed Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants