Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notes without content #6

Open
sdm7g opened this issue Feb 1, 2016 · 1 comment
Open

Notes without content #6

sdm7g opened this issue Feb 1, 2016 · 1 comment

Comments

@sdm7g
Copy link

sdm7g commented Feb 1, 2016

I found another class of errors that is not caught by schematron rules.
A number of our EAD guides were created from templates, and so we often have empty elements that have not been filled in. I did try to remove empty elements in my preprocessing, but some that are not completely empty are still empty of content.

And example of the sort of import errors generated:

The following errors were found:
notes/3/content : At least 1 item(s) is required
notes/7/subnotes/0/content : Property is required but was missing

And these are caused by EAD like this:

<abstract label="Abstract"/>

 <acqinfo encodinganalog="541$a">
        <head>Acquisition Information</head>
        <p/>
     </acqinfo>

I need to find all of the elements that map to JSONModel notes and figure out a test that catches these errors.
@fordmadox
Copy link
Owner

fordmadox commented Feb 17, 2017 •
edited
Loading

Ditto for other elements, like an empty container element (so, not just notes, it doesn't look like). We should raise a warning for a defined set of elements (head, p, container, etc.) that don't pass the [not(normalize-space()] test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fordmadox @sdm7g