Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript #88

Closed
coni2k opened this issue Jul 10, 2016 · 1 comment
Closed

Typescript #88

coni2k opened this issue Jul 10, 2016 · 1 comment

Comments

@coni2k
Copy link
Contributor

coni2k commented Jul 10, 2016

Study and start using TypeScript and convert js files to ts files

coni2k added a commit that referenced this issue Jul 10, 2016
This closes #88 and closes #89
coni2k added a commit that referenced this issue Jul 10, 2016
This closes #88 and closes #89
coni2k added a commit that referenced this issue Jul 10, 2016
* 0.62.0

This closes #88 and closes #89
@coni2k coni2k closed this as completed in a3e2793 Jul 10, 2016
@coni2k
Copy link
Contributor Author

coni2k commented Jul 12, 2016

Critical part of the operation is okay, and it's running without any issues.

  • All js files in ngClient were converted to ts, except appSettings.js
  • Debugging (sourcemaps), bundling, minification (gulp tasks) are okay

Quick to do:

  • jasmine tests will be converted and updated
  • Types are not there in most cases (using "any)
  • Some entities are using typescript classes, but some couldn't be converted:
    The problem is breeze don't allow to navigation properties be defined in entity constructors, and typescript can't use undefined properties?
  • breeze.d.ts had to be updated - one signature was not correct
  • There is no _all.ts file at the moment, is it necessary?
  • There are no d.ts files are our own ts files, is it necessary?
  • angular registrations (controllers, factories etc.), should it be inside or outside of their module? What is the difference?
  • Study tsconfig options
  • Study tsd and typings - If it works properly, add d.ts files into gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant