Unit Tests need to be completed for infrastructure

[TheOnlyRealTodd]

This is a task I'm going to take on. Sorry, I got busy the past week with some projects.

I have a question before I start though. So there have been PRs and other changes since I pulled down the repo, how do I first update my copy of this repo so that way when I make a PR, my repo is not out of sync with the main repo? I'm still trying to get the GH logistics down, I've had some nasty and scary errors in the past. Thanks.

[coni2k]

@TheOnlyRealTodd hi.

First of all, please feel to contribute any time you want, and don't think otherwise. I guess most of the open source projects only work with "no promises" approach. So, try to follow the projects you like and contribute when you have time, this is more than enough. And thanks again for being interested.

I am having problems with git and merge conflicts as well. My understanding is, in the end, with multiple contributors, there is no avoiding it. So, I am trying to get used to it.

However, to minimize the conflicts, as you already trying, it's better sync main and local before starting to a new work.

My less complicated but longer approach is; (backup your work if there are local changes,) remove your repository and fork it again. Not the right approach but always works.

Second and better approach should be something like this, in command console (both powershell and git bash should work);

git checkout forCrowd/master
git pull
git checkout master
git merge forCrowd/master
git push origin master

And the explanation;

1. Switch to forCrowd master branch
2. Get the latest updates from remote server (from github)
3. Switch to my master branch
4. Merge my master with forCrowd/master (hopefully this is not going to create any conflicts)
5. Update my remote master (on github) with my local changes

If you wish, try second approach first, if it fails, then try the first one. Let me know whether it works.

[angelfeliz]

Do the second explanation @TheOnlyRealTodd but before if you have not done this, you need to.

First you have to set up a upstream(remote branch pointing to the main repository) on git after that crate a new branch(it will be temporary only to fitch the project) then you do the second explanation from @coni2k (you merge your master branch with the temporary after the merge when OK you delete the temporary branch).

[angelfeliz]

Hello @coni2k as this Issue has not been close i will like to help on it. Is there any suggestion or specific testing framework you are or will like to use for the tests?

[coni2k]

@angelfeliz hi.
Well, that would be great. You're talking about server (.NET) side, right? Back then I tried MSTest but I don't have specific preference, what do you use?

For front-end (Angular), I'm planning to use Karma+Jasmine.

[angelfeliz]

Yes I am talking about server .NET side.

We can use NUnit, is that ok with you?

For the front-end I don't have any experiences, but I will do a research to give you a hand, if you need any collaboration.

[coni2k]

Sure, NUnit is good.

About front-end tests, I already started working on it, there will be some basic coverage. Hopefully in couple of days I will publish it, then I can let you know.

About your part, if you like, you can start with something small, couple of example tests. So we can look at it together first, before going in too deep. Sound good?

[angelfeliz]

Yes i agree

[coni2k]

I moved backend to Backbone project, in case if you want to check that one:
https://github.com/forCrowd/Backbone