Added keyboard shortcut display in tooltips #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/JuliaLoetfering/Pluto.jl", rev="Add-Cell-shortcut")
julia> using Pluto |
Pangoraw
reviewed
Sep 5, 2023
frontend/components/RunArea.js
Outdated
| @@ -36,7 +36,7 @@ export const RunArea = ({ | |||
| interrupt: "Interrupt", | |||
| save: "Save code without running", | |||
| jump: "This cell depends on a disabled cell", | |||
| run: "Run cell", | |||
| run: "Run cell (Shift + Enter) <3", | |||
There was a problem hiding this comment.
Is it an oversight?
Suggested change
| run: "Run cell (Shift + Enter) <3", | |
| run: "Run cell (Shift + Enter)", |
There was a problem hiding this comment.
Oh yes, I'm sorry ^^ I was testing something out and forgot to remove it.
frontend/components/CellInput.js
Outdated
| @@ -909,7 +909,7 @@ const InputContextMenu = ({ on_delete, cell_id, run_cell, skip_as_script, runnin | |||
| <span class="icon"></span> | |||
| ${open | |||
| ? html`<ul onMouseenter=${mouseenter}> | |||
| <li onClick=${on_delete} title="Delete"><span class="delete ctx_icon" />Delete cell</li> | |||
| <li onClick=${on_delete} title="Delete (Ctrl + Backspace)"><span class="delete ctx_icon" />Delete cell</li> | |||
There was a problem hiding this comment.
Backspace actually deletes only when the code is empty so we can remove this one (https://github.com/fonsp/Pluto.jl/wiki/%F0%9F%94%8E-Basic-Commands-in-Pluto#5-delete-a-cell).
There was a problem hiding this comment.
You're right, that totally makes scence. Thank you!
|
Thank you @JuliaLoetfering !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least for "run cell, add cell, interrupt and delete currant cell" I added the keyboard shortcut display as adressed in #1065