Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in docstring #2648

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Fix typo in docstring #2648

merged 2 commits into from
Sep 15, 2023

Conversation

LilithHafner
Copy link
Contributor

The primary change here is:

...snoop out all methods that we defined by us, and not by another package...

to

...snoop out all methods that were defined by us, and not by another package...

My editor also automatically stripped out trailing whitespace on file save, I hope that's okay. I can put back the trailing whitespace if necessary.

@github-actions
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/LilithHafner/Pluto.jl", rev="lh/doc-typo")
julia> using Pluto

@pankgeorg
Copy link
Collaborator

Thanks for contributing! I'm not sure what our policy on whitespace is (it kind of messes up the git history); but if this PR only had the one changed line I'll approve it right away!

Copy link
Collaborator

@pankgeorg pankgeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You can make a new white space PR if you want and we can discuss that there! Or maybe even a formatter one. (It would be super cool if the commit message for each line referenced the previous commit of each line, but I don't know if there is any tool that actually does that)

@pankgeorg pankgeorg merged commit a86709b into fonsp:main Sep 15, 2023
@LilithHafner LilithHafner deleted the lh/doc-typo branch September 16, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants