Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Julia 1.10 #2626

Merged
merged 3 commits into from
Aug 13, 2023
Merged

Test Julia 1.10 #2626

merged 3 commits into from
Aug 13, 2023

Conversation

Pangoraw
Copy link
Collaborator

@Pangoraw Pangoraw commented Aug 9, 2023

It seems that 1.10 is around the corner, let's test it!

Note: There is a problem with FuzzyCompletions.jl which should be adressed in:

It seems that 1.10 is around the corner, let's test it!
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="julia_1.10")
julia> using Pluto

@Pangoraw
Copy link
Collaborator Author

Pangoraw commented Aug 9, 2023

Test fails because #2560 is not included in [email protected] (from #2560 (comment)):

@test Distributed.remotecall_eval(Main, p, quote
nb.cells[2].errored == false
end)

EDIT: The test is now disabled for VERSION >= 1.10 (we might want to reenable with a solution).

@Pangoraw Pangoraw merged commit f297b12 into main Aug 13, 2023
@Pangoraw Pangoraw deleted the julia_1.10 branch August 13, 2023 09:52
fonsp added a commit that referenced this pull request Sep 12, 2023
The test should run in 1.9 versions, but not in 1.10 and later.
@fonsp
Copy link
Owner

fonsp commented Sep 12, 2023

@Pangoraw can you check that 394be90 is correct?

@Pangoraw
Copy link
Collaborator Author

oops, the previous check disabled the test for 1.9.xx too, should be good now, thanks!

@fonsp fonsp mentioned this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants