Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accordion] exclusive accordions should call their callbacks for both the opening and the closing element #2826

Open
ddabble opened this issue Jun 16, 2023 · 1 comment
Labels
lang/javascript Anything involving JavaScript state/has-pr An issue which has a related PR open type/feat Any feature requests or improvements
Milestone

Comments

@ddabble
Copy link

ddabble commented Jun 16, 2023

Feature Request

For accordions with the exclusive setting set to true, when one element is already open and the user opens another element (so that the first one automatically closes), the callbacks in the settings section of the docs are only called for the element that is opened, and not the one that is closed (as of FUI v2.9.2).

It would be useful to have the callbacks called for both affected elements, so that the developer does not have to iterate over the other elements to find which one was affected, in case they want to do something with it. (In my case - which motivated opening this issue - it's to set the aria-expanded attribute to true/false, as well as setting the inert attribute on closing accordion .content to prevent keyboard focus while the closing animation is playing.)

Example (if possible)

If the explanation above is not entirely clear, do post a comment, and I can create an example 🙂

Screenshot (if possible)

@ddabble ddabble added state/awaiting-triage Any issues or pull requests which haven't yet been triaged type/feat Any feature requests or improvements labels Jun 16, 2023
@ko2in ko2in added lang/javascript Anything involving JavaScript and removed state/awaiting-triage Any issues or pull requests which haven't yet been triaged labels Jun 20, 2023
@lubber-de
Copy link
Member

Fixed by #2879

@lubber-de lubber-de added the state/has-pr An issue which has a related PR open label Aug 19, 2023
@lubber-de lubber-de modified the milestones: 2.10.x, 2.9.3 Aug 19, 2023
@lubber-de lubber-de modified the milestones: 2.9.3, 2.9.x Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/javascript Anything involving JavaScript state/has-pr An issue which has a related PR open type/feat Any feature requests or improvements
Projects
None yet
Development

No branches or pull requests

3 participants