Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getIndexForDaySmartSymbol() function #721

Open
geosaaga opened this issue Dec 3, 2024 · 0 comments
Open

Fix getIndexForDaySmartSymbol() function #721

geosaaga opened this issue Dec 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@geosaaga
Copy link
Collaborator

geosaaga commented Dec 3, 2024

The function

export const getIndexForDaySmartSymbol = (dayArray: TimeStepData[]): number => {

doesn't work for the last day of forecast. It returns quite random symbol depending how long the forecast is. The issue is visible especially during winter time, because it may return day symbol instead of night symbol when sun sets early.

The function should be fixed to use local time instead of handling indexes.

@geosaaga geosaaga added the bug Something isn't working label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant