Added conditional_before_commands #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niklas Spielbauer <[email protected]>
nspielbau
force-pushed
the
conditional_before_commands
branch
from
de4d9b3 to
4543df7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 89.24% 89.65% +0.41%
==========================================
Files 6 6
Lines 251 261 +10
==========================================
+ Hits 224 234 +10
Misses 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Niklas Spielbauer <[email protected]>
Signed-off-by: Niklas Spielbauer <[email protected]>
Signed-off-by: Niklas Spielbauer <[email protected]>
Signed-off-by: Niklas Spielbauer <[email protected]>
|
I tested this locally with the new example_session layout and it seemed to work, the last commit was to fix an issue that is currently not caught by the test coverage tho, but I am not sure why it is not as the session was not created correctly... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #48