propagate dark/light theme to algolia search bar #5231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cosmicBboy <[email protected]>
dosubot
bot
added
size:M
pingsutw
previously approved these changes
Apr 14, 2024
Signed-off-by: cosmicBboy <[email protected]>
|
@pingsutw another +1 please! |
Signed-off-by: cosmicBboy <[email protected]>
Signed-off-by: cosmicBboy <[email protected]>
pingsutw
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Currently, the algolia search bar maintains the light theme even when dark mode is toggled:
What changes were proposed in this pull request?
This PR propogates the
data-theme="light/dark/auto"setting that the furo sphinx theme handles from thebodyelement to the roothtmlelement.How was this patch tested?
Built the docs locally with
make docs