From d08a4c22f2192e24ad348d4e8be1d34d1b44faec Mon Sep 17 00:00:00 2001
From: Guy Arad <gmorphus@hotmail.com>
Date: Tue, 31 Oct 2023 15:01:28 +0200
Subject: [PATCH] fixes deployment template readiness and liveness probes with
 correct port

Signed-off-by: Guy Arad <gmorphus@hotmail.com>
---
 charts/flyte-binary/templates/deployment.yaml              | 6 ++++--
 .../flyte_sandbox_binary_helm_generated.yaml               | 6 ++++--
 script/generate_helm.sh                                    | 7 ++++++-
 3 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/charts/flyte-binary/templates/deployment.yaml b/charts/flyte-binary/templates/deployment.yaml
index cc8beff2d9e..693a488db41 100644
--- a/charts/flyte-binary/templates/deployment.yaml
+++ b/charts/flyte-binary/templates/deployment.yaml
@@ -192,7 +192,8 @@ spec:
           {{- else }}
             httpGet:
               path: /healthcheck
-              port: http
+              port: 8088
+            initialDelaySeconds: 60
           {{- end }}
           readinessProbe:
           {{- if .Values.deployment.readinessProbe }}
@@ -200,7 +201,8 @@ spec:
           {{- else }}
             httpGet:
               path: /healthcheck
-              port: http
+              port: 8088
+            initialDelaySeconds: 60
           {{- end }}
           {{- if .Values.deployment.resources }}
           resources: {{- toYaml .Values.deployment.resources | nindent 12 }}
diff --git a/deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml b/deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml
index a72612995d4..f7344d802cd 100644
--- a/deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml
+++ b/deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml
@@ -416,11 +416,13 @@ spec:
           livenessProbe:
             httpGet:
               path: /healthcheck
-              port: http
+              port: 8088
+            initialDelaySeconds: 60
           readinessProbe:
             httpGet:
               path: /healthcheck
-              port: http
+              port: 8088
+            initialDelaySeconds: 60
           volumeMounts:
             - name: cluster-resource-templates
               mountPath: /etc/flyte/cluster-resource-templates
diff --git a/script/generate_helm.sh b/script/generate_helm.sh
index 183b22debc8..43caee82033 100755
--- a/script/generate_helm.sh
+++ b/script/generate_helm.sh
@@ -4,9 +4,14 @@ set -ex
 
 echo "Generating Helm"
 
-curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash
+HELM_SKIP_INSTALL=${HELM_SKIP_INSTALL:-false}
+
+if [ "${HELM_SKIP_INSTALL}" != "true" ]; then
+    curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash
+fi
 
 helm version
+
 # All the values files to be built
 DEPLOYMENT_CORE=${1:-eks gcp}