From 6e6048d2e5e223366f1e5fb7f0f7bc8156b367dd Mon Sep 17 00:00:00 2001 From: Yini Date: Tue, 19 Mar 2024 14:05:49 +0100 Subject: [PATCH] add comment to warn user the unsupported combo Signed-off-by: Yini --- .../values-keycloak-idp-flyteclients-without-browser.yaml | 1 + charts/flyte-core/values.yaml | 1 + docs/deployment/configuration/auth_setup.rst | 1 + 3 files changed, 3 insertions(+) diff --git a/charts/flyte-core/values-keycloak-idp-flyteclients-without-browser.yaml b/charts/flyte-core/values-keycloak-idp-flyteclients-without-browser.yaml index 68dbeb594d..505ac17149 100644 --- a/charts/flyte-core/values-keycloak-idp-flyteclients-without-browser.yaml +++ b/charts/flyte-core/values-keycloak-idp-flyteclients-without-browser.yaml @@ -303,6 +303,7 @@ secrets: # https://docs.flyte.org/en/latest/deployment/cluster_config/auth_setup.html#oauth2-authorization-server # If mount is true, helm will mount `flyte-secret-auth`. # If mount is false, helm will not mount `flyte-secret-auth`. + # Note: Unsupported combination: create.true and mount.false. create: true mount: true clientSecret: "<>" # put the secret for the confidential client flytepropeller defined in the IDP diff --git a/charts/flyte-core/values.yaml b/charts/flyte-core/values.yaml index ae59ef1754..c2ae55acf1 100755 --- a/charts/flyte-core/values.yaml +++ b/charts/flyte-core/values.yaml @@ -435,6 +435,7 @@ secrets: # https://docs.flyte.org/en/latest/deployment/cluster_config/auth_setup.html#oauth2-authorization-server # If mount is true, helm will mount `flyte-secret-auth`. # If mount is false, helm will not mount `flyte-secret-auth`. + # Note: Unsupported combination: create.true and mount.false. create: true mount: true clientSecret: foobar diff --git a/docs/deployment/configuration/auth_setup.rst b/docs/deployment/configuration/auth_setup.rst index 026874650f..46e8a0df36 100644 --- a/docs/deployment/configuration/auth_setup.rst +++ b/docs/deployment/configuration/auth_setup.rst @@ -350,6 +350,7 @@ Apply OIDC Configuration # https://docs.flyte.org/en/latest/deployment/cluster_config/auth_setup.html#oauth2-authorization-server # If mount is true, helm will mount `flyte-secret-auth`. # If mount is false, helm will not mount `flyte-secret-auth`. + # Note: Unsupported combination: create.true and mount.false. create: true mount: true # Use the non-encoded version of the random password