Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flycheck-ocaml and 'dune-project' file #15

Open
Fourchaux opened this issue Nov 2, 2022 · 0 comments · May be fixed by #16
Open

Flycheck-ocaml and 'dune-project' file #15

Fourchaux opened this issue Nov 2, 2022 · 0 comments · May be fixed by #16

Comments

@Fourchaux
Copy link

Configuration:
OCaml 4.14.0 - Emacs 29.0.50 - Tuareg (v3.0.1) - Merlin (v4.6-414, for OCaml 4.14.0) - Linux Box x86_64

After having tried several OCaml files (some very old and in any case without using Dune)
it seems that the mere presence of a 'dune-project' file (even empty!) is enough to activate Flycheck-ocaml.

Is this behavior general?

If so, it would be good to modify the README by specifying this simplification.
(No need to setup a Dune project and run dune build)
temyurchenko added a commit to temyurchenko/flycheck-ocaml that referenced this issue Jan 6, 2024
@temyurchenko
Enable the checker in .merlin presence
3f2e52d 
Problem: some projects don't use Dune, while using Merlin, configured
   with the .merlin file. `flycheck-ocaml` is only turned on if the
   «dune-project» file is present though. As a result,
   `flycheck-ocaml` is disabled for such projects.

Solution: enable the `flycheck-ocaml` checker if either dune-project
   or .merlin are present.

In a round-about way this fixes flycheck#15. People who don't use Dune, don't
   need to create an empty dune-project to use the checker, which was
   misleading.
@temyurchenko temyurchenko linked a pull request Jan 6, 2024 that will close this issue
Open
temyurchenko added a commit to temyurchenko/flycheck-ocaml that referenced this issue Jan 6, 2024
@temyurchenko
Enable the checker in .merlin presence
9eb77f1 
Problem: some projects don't use Dune, while using Merlin, configured
   with the .merlin file. `flycheck-ocaml` is only turned on if the
   «dune-project» file is present though. As a result,
   `flycheck-ocaml` is disabled for such projects.

Solution: enable the `flycheck-ocaml` checker if either dune-project
   or .merlin are present.

In a round-about way this fixes flycheck#15. People who don't use Dune, don't
   need to create an empty dune-project to use the checker, which was
   misleading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable the checker in .merlin presence temyurchenko/flycheck-ocaml
1 participant
@Fourchaux