From 1be902836ee1b46d273653b331fc99e97abf9264 Mon Sep 17 00:00:00 2001 From: Sean Eagan Date: Thu, 18 Apr 2024 14:34:14 -0500 Subject: [PATCH] Fix DependsOn readiness check --- internal/controller/helmrelease_controller.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/controller/helmrelease_controller.go b/internal/controller/helmrelease_controller.go index ba7c0fe85..b02501a06 100644 --- a/internal/controller/helmrelease_controller.go +++ b/internal/controller/helmrelease_controller.go @@ -585,7 +585,7 @@ func (r *HelmReleaseReconciler) checkDependencies(ctx context.Context, obj *v2.H return fmt.Errorf("unable to get '%s' dependency: %w", ref, err) } - if dHr.Generation != dHr.Status.ObservedGeneration || !conditions.IsTrue(dHr, meta.ReadyCondition) { + if dHr.Generation != conditions.GetObservedGeneration(dHr, meta.ReadyCondition) || !conditions.IsTrue(dHr, meta.ReadyCondition) { return fmt.Errorf("dependency '%s' is not ready", ref) } }