Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt workflows #261

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Adapt workflows #261

merged 2 commits into from
Jan 26, 2024

Conversation

souleb
Copy link
Member

@souleb souleb commented Jan 25, 2024

Description

Adapting github action workflows to have the same behaviour across providers.

Set same behaviour for all providers

Signed-off-by: Soule BA <[email protected]>
Signed-off-by: Soule BA <[email protected]>
@darkowlzz
Copy link

oh my approval doesn't count in this repository 😄
But the DCO check is failing https://github.com/fluxcd/go-git-providers/pull/261/checks?check_run_id=20865958577. For some reason it expects your old email address for sign-off.

@stefanprodan
Copy link
Member

No idea how to fix the DCO bot, it's really annoying.

@darkowlzz
Copy link

If you look at https://patch-diff.githubusercontent.com/raw/fluxcd/go-git-providers/pull/261.patch, the commit was authored using the old email address. Maybe that is what's causing this conflict. Updating the git email address in ~/.gitconfig should commit using the new email address and hopefully fix this.

@souleb souleb merged commit 5231570 into main Jan 26, 2024
8 of 9 checks passed
@souleb souleb deleted the adapt-workflows branch January 26, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants