Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support using HTTP proxies for connecting to provider APIs #188

Open
makkes opened this issue Feb 22, 2023 · 1 comment
Open

Support using HTTP proxies for connecting to provider APIs #188

makkes opened this issue Feb 22, 2023 · 1 comment
Assignees
@makkes
Labels
enhancement New feature or request

Comments

@makkes
Copy link
Member

makkes commented Feb 22, 2023

In certain (private or corporate) environments usage of an HTTP proxy is mandatory to connect to services inside or outside of the environment. go-git-providers should support these use cases by consuming the HTTP_PROXY and HTTPS_PROXY environment variables.
@makkes makkes added the enhancement New feature or request label Feb 22, 2023
@makkes makkes moved this to Up-Next in Maintainers' Focus Mar 2, 2023
@makkes makkes moved this from Up-Next to In Progress in Maintainers' Focus Mar 3, 2023
@makkes makkes self-assigned this Mar 3, 2023
@makkes
Copy link
Member Author

makkes commented Mar 4, 2023

From what I saw in manual tests was that those proxy variables are taken into account. I'll probably come up with a smoke test for each provider to make sure this behavior is supported by all providers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@makkes makkes

Labels
enhancement New feature or request
Projects
Maintainers' Focus
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@makkes