API definitions contain invalid tag genclient:Namespaced

[gmolau]

Many API definitions of the Flux project contain a tag genclient:Namespaced. This tag isn't actually used by controller-tools, only nonNamespaced.

Having this tag does not create immediate problems, but can trip up other tools that validate the tags, e.g. applyconfiguration-gen here.

Originally discussed in the CNCF Slack here.

PRs to remove this tag everywhere:

• Remove genclient:Namespaced tag helm-controller#901
• Remove genclient:Namespaced tag kustomize-controller#1092
• Remove genclient:Namespaced tag source-controller#1386
• Remove genclient:Namespaced tag notification-controller#749
• Remove genclient:Namespaced tag pkg#740

[stefanprodan]

@gmolau I think we have it in the image automation controllers too. Can you please do the changes there as well?

[gmolau]

The image controllers don't use it, see https://github.com/search?q=%2Fgenclient%3ANamespaced%2F+org%3Afluxcd&type=code

I had missed one in pkg though, added this now.

[gmolau]

@stefanprodan Can you trigger a release for these updates? I know I could depend on the commits directly, but I would like to keep the version of my Docker images in sync with the lib.

[stefanprodan]

@gmolau these changes will be included in the next minor scheduled for mid April.