-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canary analysis restart again and again when using Gateway API #1712
Comments
mingjie-li
pushed a commit
to mingjie-li/flagger
that referenced
this issue
Oct 18, 2024
mingjie-li
pushed a commit
to mingjie-li/flagger
that referenced
this issue
Oct 18, 2024
Signed-off-by: Mingjie Li <[email protected]>
PR here -> #1713 |
mingjie-li
pushed a commit
to mingjie-li/flagger
that referenced
this issue
Oct 26, 2024
Signed-off-by: Mingjie Li <[email protected]>
louishalbritter
pushed a commit
to louishalbritter/flagger
that referenced
this issue
Dec 17, 2024
Signed-off-by: Mingjie Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When iterating over a map in Go, the order of elements is not guaranteed and may vary between iterations. In the context of the Gateway API provider, the four following maps:
are transformed into four slices, where the order becomes significant when comparing using go-cmp.
If sessionAffinity or Mirror is used, the comparison of these slices will be ignored. However, in other cases, any differences in the slices will lead the Flagger operator to believe that the HttpRoute has changed, triggering unnecessary canary analysis restarts."
To Reproduce
run canary analysis with gateway api without sessionAffinity or Mirror
Expected behavior
canary analysis run only once
Additional context
The text was updated successfully, but these errors were encountered: