Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken: Adding new assets and markets over the REST API #371

Open
gcomte opened this issue Dec 18, 2021 · 1 comment
Open

Broken: Adding new assets and markets over the REST API #371

gcomte opened this issue Dec 18, 2021 · 1 comment
Assignees

Comments

@gcomte
Copy link
Contributor

gcomte commented Dec 18, 2021

The test examples/js/tests/set_markets.ts doesn't run through.
It is broken on many levels:

  • The constants new_asset as well as new_market1 and new_market2 in the file examples/js/tests/set_markets.ts need additional arguments to fit the REST interface (See structs NewAssetReq and NewTradePairReq in file src/restapi/types.rs for more details.
  • The base and quote attribute for a new market needs to be a string rather than an object (eg. base: "BTC", rather than base: { name: "BTC", prec: 2 },)
  • The new asset-call does not persist for some reason, without throwing any error. Maybe it is because of the on conflict do nothing-part in the file src/storage/config.rs (function persist_asset_to_db)
  • ... might require additional fixes
@0xmountaintop
Copy link
Member

Thanks for reporting the bug, we will look into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants