Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate builtins #1378

Open
1 of 2 tasks
dsalaza4 opened this issue Sep 6, 2024 · 3 comments
Open
1 of 2 tasks

Deprecate builtins #1378

dsalaza4 opened this issue Sep 6, 2024 · 3 comments
Assignees
@dsalaza4

Comments

@dsalaza4
Copy link
Contributor

dsalaza4 commented Sep 6, 2024 •
edited
Loading

Their learning curve is higher than language-specific tools.

Errors require high nix knowledge to debug.

We mainly use them to keep language-specific dependencies as derivations for cache, but for large projects, many times running npm ci is faster than makeNodeJsModules.

I would advise getting rid of all builtins that focus on building language-specific dependencies as derivations and install them on runtime using poetry install or npm ci

Deprecate:

  • makeNodeJs*
  • makePython*
@dsalaza4 dsalaza4 mentioned this issue Sep 6, 2024
Closed
@rohaquinlop rohaquinlop mentioned this issue Oct 22, 2024
Open
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 22, 2024
@rohaquinlop
feat(build): fluidattacks#1378 deprecate makenodejs
b05174f 
- Deprecate `makeNodeJsModules` and `makeNodeJsEnvironment`.

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 22, 2024
@rohaquinlop
feat(build): fluidattacks#1378 deprecate makenodejs
bce00f7 
- Deprecate `makeNodeJsModules` and `makeNodeJsEnvironment`.

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 22, 2024
@rohaquinlop
feat(build): fluidattacks#1378 deprecate makenodejs
41e850f 
- Deprecate `makeNodeJsModules` and `makeNodeJsEnvironment`.

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 22, 2024
@rohaquinlop
feat(build): fluidattacks#1378 deprecate makenodejs
067d3ed 
- Deprecate `makeNodeJsModules` and `makeNodeJsEnvironment`.

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 23, 2024
@rohaquinlop
feat(build): fluidattacks#1378 deprecate makenodejs
ee4b8f1 
- Deprecate `makeNodeJsModules` and `makeNodeJsEnvironment`.

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 23, 2024
@rohaquinlop
feat(build): fluidattacks#1378 deprecate makenodejs
7750a71 
- Deprecate `makeNodeJsModules` and `makeNodeJsEnvironment`.

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 23, 2024
@rohaquinlop
feat(build): fluidattacks#1378 deprecate makenodejs
ea04362 
- Deprecate `makeNodeJsModules` and `makeNodeJsEnvironment`.

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 23, 2024
@rohaquinlop
feat(build): fluidattacks#1378 deprecate makenodejs
20ef121 
- Deprecate `makeNodeJsModules` and `makeNodeJsEnvironment`.

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 23, 2024
@rohaquinlop
feat(build): fluidattacks#1378 deprecate makenodejs
221d988 
- Deprecate `makeNodeJsModules` and `makeNodeJsEnvironment`.

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 23, 2024
@rohaquinlop
feat(build): fluidattacks#1378 deprecate makenodejs
f6279bf 
- Deprecate `makeNodeJsModules` and `makeNodeJsEnvironment`.

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 23, 2024
@rohaquinlop
feat(build): fluidattacks#1378 deprecate makenodejs
1f2405d 
- Deprecate `makeNodeJsModules` and `makeNodeJsEnvironment`.

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Oct 23, 2024
@rohaquinlop
feat(build): fluidattacks#1378 deprecate makenodejs
c34b1bd 
- Deprecate `makeNodeJsModules` and `makeNodeJsEnvironment`.

Signed-off-by: Robin Quintero <[email protected]>
dsalaza4 added a commit that referenced this issue Oct 23, 2024
@dsalaza4
Merge pull request #1386 from rohaquinlop/issue-1378
be86603 
feat(build): #1378 deprecate makenodejs
@dsalaza4 dsalaza4 mentioned this issue Dec 12, 2024
Closed
@dsalaza4 dsalaza4 changed the title Deprecate poetry2nix and node2nix Deprecate builtins Dec 12, 2024
@dsalaza4
Copy link
Contributor Author

dsalaza4 commented Dec 12, 2024 •
edited
Loading

Let's also deprecate:

  • testPython
  • calculateScorecard
  • lintPython
  • formatPython
  • securePythonWithBandit
  • secureKubernetesWithRbacPolice
  • deployNomad
  • taintTerraform
  • lintClojure
  • workspaceForTerraformFromEnv
  • makeSopsEncryptedFile
  • secretsForKubernetesConfigFromAws
  • formatJavascript
  • formatScala
  • lintWithLizard

dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 12, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate test python
ddc6a49 
- Deprecate testPython
as it is too specific to the python language
and lacks too much flexibility.
- Remove documentation

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 12, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate test python
abc2e3c 
- Deprecate testPython
as it is too specific to the python language
and lacks too much flexibility.
- Remove jobs from pipeline
- Remove documentation

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 12, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate test python
2bd50a6 
- Deprecate testPython
as it is too specific to the python language
and lacks too much flexibility.
- Remove unused tests
- Remove unused autocomplete
- Remove jobs from pipeline
- Remove documentation

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 12, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate test python
0bd499e 
- Deprecate testPython
as it is too specific to the python language
and lacks too much flexibility.
- Remove unused tests
- Remove unused autocomplete
- Remove jobs from pipeline
- Remove documentation

Signed-off-by: Daniel Salazar <[email protected]>
jandresh added a commit that referenced this issue Dec 12, 2024
@jandresh
Merge pull request #1392 from dsalaza4/main
10b061b 
refac(back): #1378 deprecate test python
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 12, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate calculate scorecard
7d372b9 
- Deprecate calculate scorecard
as it easily breaks with false positives
and we're not using it
- Remove jobs from pipeline
- Remove documentation

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 12, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate calculate scorecard
71f1239 
- Deprecate calculate scorecard
as it easily breaks with false positives
and we're not using it
- Remove jobs from pipeline
- Remove documentation

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 12, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate calculate scorecard
a487f2f 
- Deprecate calculate scorecard
as it easily breaks with false positives
and we're not using it
- Remove jobs from pipeline
- Remove documentation

Signed-off-by: Daniel Salazar <[email protected]>
jandresh added a commit that referenced this issue Dec 12, 2024
@jandresh
Merge pull request #1393 from dsalaza4/main
37bc7bf 
refac(back): #1378 deprecate calculate scorecard
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 12, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate bandit
120f8fa 
- Deprecate secure python with bandit
as ruff replaces it
- Remove jobs from pipeline
- Remove documentation

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit that referenced this issue Dec 12, 2024
@dsalaza4
Merge pull request #1394 from dsalaza4/main
907e7d5 
refac(back): #1378 deprecate bandit
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 12, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate rbacpolice
1c2b0bd 
- Deprecate secure k8s with rbacpolice
as we already perform this process via machine
and rbacpolice is not being maintained anymore
- Remove documentation

Signed-off-by: Daniel Salazar <[email protected]>
jandresh added a commit that referenced this issue Dec 13, 2024
@jandresh
Merge pull request #1403 from dsalaza4/main
aead72f 
refac(back): #1378 deprecate lint python
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 13, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate format python
faf7528 
- Deprecate formatPython as it was replaced by ruff
- Remove documentation
- Remove CI jobs

Signed-off-by: Daniel Salazar <[email protected]>
jandresh added a commit that referenced this issue Dec 13, 2024
@jandresh
Merge pull request #1404 from dsalaza4/main
2a12307 
refac(back): #1378 deprecate format python
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 13, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate k8s config from aws
2e663c6 
- Deprecate secretsForKubernetesConfigFromAws
as it is not being used
- Remove documentation

Signed-off-by: Daniel Salazar <[email protected]>
@dsalaza4 dsalaza4 self-assigned this Dec 13, 2024
jandresh added a commit that referenced this issue Dec 13, 2024
@jandresh
Merge pull request #1405 from dsalaza4/main
06527a7 
refac(back): #1378 deprecate k8s config from aws
@dsalaza4
Copy link
Contributor Author

Let's also deprecate:

  • testPython
  • calculateScorecard
  • lintPython
  • formatPython
  • securePythonWithBandit
  • secureKubernetesWithRbacPolice
  • deployNomad
  • taintTerraform
  • lintClojure
  • workspaceForTerraformFromEnv
  • makeSopsEncryptedFile
  • secretsForKubernetesConfigFromAws
  • formatJavascript
  • formatScala
  • lintWithLizard

I will release a major makes version deprecating all these builtins (low impact)

dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 13, 2024
@dsalaza4
feat(cross): fluidattacks#1378 new version
0c73fc1 
- Add new 24.12 pre-release version
- Make 24.09 stable version

Signed-off-by: Daniel Salazar <[email protected]>
jandresh added a commit that referenced this issue Dec 13, 2024
@jandresh
Merge pull request #1406 from dsalaza4/main
2fba6e0 
feat(cross): #1378 new version
@dsalaza4
Copy link
Contributor Author

dsalaza4 commented Dec 13, 2024 •
edited
Loading

Deprecate:

  • lintGitCommitMsg
  • calculateCvss3
  • chunks
  • escapeShellArg
  • escapeShellArgs
  • filterAttrs
  • flatten
  • fromToml
  • makeDerivationParallel
  • makeNomadEnvironment
  • sortAscii
  • sortAsciiCaseless
  • secretsForGpgFromEnv
  • helloWorld
  • makeSecretForNomadFromEnv
  • makeSecretForKubernetesConfigFromAws
  • makeScriptParallel

dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 13, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate commit linter
6d89b89 
- Deprecate lintGitCommitMsg as we're no longer
using it
- Create a simplified job for linting commit msg
- Remove documentation
- Adapt CI jobs

Signed-off-by: Daniel Salazar <[email protected]>
jandresh added a commit that referenced this issue Dec 13, 2024
@jandresh
Merge pull request #1407 from dsalaza4/main
208c374 
refac(back): #1378 deprecate commit linter
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 13, 2024
@dsalaza4
refac(cross): fluidattacks#1378 deprecate internal builtins
07dda47 
- Deprecate calculateCvss3
- Deprecate chunks
- Deprecate escapeShellArg
- Deprecate escapeShellArgs
- Deprecate filterAttrs
- Deprecate flatten
- Deprecate fromToml
- Deprecate makeDerivationParallel
- Deprecate makeNomadEnvironment
- Deprecate sortAscii
- Deprecate sortAsciiCaseless
- Adapt source code
- Remove documentation
- Remove CI jobs
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 13, 2024
@dsalaza4
refac(cross): fluidattacks#1378 deprecate internal builtins
85330f8 
- Deprecate calculateCvss3
- Deprecate chunks
- Deprecate escapeShellArg
- Deprecate escapeShellArgs
- Deprecate filterAttrs
- Deprecate flatten
- Deprecate fromToml
- Deprecate makeDerivationParallel
- Deprecate makeNomadEnvironment
- Deprecate sortAscii
- Deprecate sortAsciiCaseless
- Adapt source code
- Remove documentation
- Remove CI jobs

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 13, 2024
@dsalaza4
refac(cross): fluidattacks#1378 deprecate internal builtins
9fb257a 
- Deprecate calculateCvss3
- Deprecate chunks
- Deprecate escapeShellArg
- Deprecate escapeShellArgs
- Deprecate filterAttrs
- Deprecate flatten
- Deprecate fromToml
- Deprecate makeDerivationParallel
- Deprecate makeNomadEnvironment
- Deprecate sortAscii
- Deprecate sortAsciiCaseless
- Adapt source code
- Remove documentation
- Remove CI jobs

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit that referenced this issue Dec 13, 2024
@dsalaza4
Merge pull request #1408 from dsalaza4/main
7c9620d 
refac(cross): #1378 deprecate internal builtins
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 19, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate secrets for gpg
c229856 
- Deprecate builtin
- Deprecate tests
- Remove secretsForEnvFromSops tests
as it will be removed in the future
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 19, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate secrets for gpg
ab85621 
- Deprecate builtin
- Deprecate tests
- Remove secretsForEnvFromSops tests
as it will be removed in the future

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 19, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate secrets for gpg
52aa40b 
- Deprecate builtin
- Deprecate tests
- Remove secretsForEnvFromSops tests
as it will be removed in the future

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 19, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate secrets for gpg
6b3356c 
- Deprecate builtin
- Deprecate tests
- Remove secretsForEnvFromSops tests
as it will be removed in the future

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 19, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate secrets for gpg
9a27d5a 
- Deprecate builtin
- Deprecate tests
- Remove secretsForEnvFromSops tests
as it will be removed in the future

Signed-off-by: Daniel Salazar <[email protected]>
drestrepom added a commit that referenced this issue Dec 19, 2024
@drestrepom
Merge pull request #1417 from dsalaza4/main
c341bbd 
refac(back): #1378 deprecate secrets for gpg
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 19, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate hello world
30d29c3 
- Deprecate builtin
- Deprecate tests
- Adapt CI
- Adapt documentation

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit that referenced this issue Dec 19, 2024
@dsalaza4
Merge pull request #1418 from dsalaza4/main
fe49378 
refac(back): #1378 deprecate hello world
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 19, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate builtins
16407ff 
- Deprecate makeSecretForAwsFromGitlab
- Deprecate makeSecretForKubernetesConfigFromAws
- Deprecate makeSecretForNomadFromEnv

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 19, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate builtins
401e3f6 
- Deprecate makeSecretForAwsFromGitlab
- Deprecate makeSecretForKubernetesConfigFromAws
- Deprecate makeSecretForNomadFromEnv
- Deprecate makeScriptParallel

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit that referenced this issue Dec 19, 2024
@dsalaza4
Merge pull request #1419 from dsalaza4/main
226f3a1 
refac(back): #1378 deprecate builtins
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 19, 2024
@dsalaza4
refac(back): fluidattacks#1378 deprecate builtins
aed29d5 
- Deprecate makeEnvVars
- Deprecate makeEnvVarsForTerraform
- Deprecate makeSecretForEnvFromSops
- Deprecate makeSecretForTerraformFromEnv

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit to dsalaza4/makes that referenced this issue Dec 19, 2024
@dsalaza4
refac(back): fluidattacks#1378 recover builtin
c020cac 
- Recover secretsForAwsFromGitlab
as it is currently being used

Signed-off-by: Daniel Salazar <[email protected]>
dsalaza4 added a commit that referenced this issue Dec 19, 2024
@dsalaza4
Merge pull request #1421 from dsalaza4/main
be8e013 
refac(back): #1378 recover builtin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsalaza4 dsalaza4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsalaza4