Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support leading v syntax in version strings #153

Open
kaedys opened this issue Jul 21, 2021 · 0 comments
Open

Support leading v syntax in version strings #153

kaedys opened this issue Jul 21, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@kaedys
Copy link

kaedys commented Jul 21, 2021

Problem description
Version strings that use a leading v, as in v1.2.3, are a very common format in software versioning, making it clear that the number indicated is a version tag. Authors sometimes either prefer to use this style, or do so forgetfully.

Specifically, one of the mods I use, TargetingModes, updated their version tag to <version>v2.1.0</version>, which is now throwing parse errors.

Describe the solution
Tolerate a leading v on version strings. If the first character is a v, discard it and treat the remainder as a normal semantic version using the existing logic.

Alternatives
Don't believe there is an alternative, other than the existing state, which simply expects all developers to remember to conform to this versioning style. I understand that Microsoft, when writing the .NET standard, did not embrace a leading v, but that doesn't necessarily imply that Mod Manager can't or shouldn't.

Additional materials
It's worth noting that I'm not the author of the offending Manifest.xml. I'm also sure that while this is almost assuredly not an isolated incident, it's also probably not that common. I hope. But it feels like the type of flexibility a mod management application should have. v prefixes are very very very very common in software versioning, and I feel like it makes sense to support that versioning style.

For reference, here's the commit in question. The original author of the mod stepped away, and OdysseyScorpio took it over, which is likely why the versioning scheme changed.

@kaedys kaedys added the enhancement New feature or request label Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant