Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: inconsistent behaviour for setting FluentBit labels and annotations #1424

Open
jjsiv opened this issue Nov 29, 2024 · 0 comments
Open

Comments

@jjsiv
Copy link
Collaborator

jjsiv commented Nov 29, 2024

Describe the issue

Setting FluentBit.Spec.Labels will set labels on both the DaemonSet and the pods.
Setting FluentBit.Spec.Annotations will set annotations only on the pods.

To Reproduce

Create a FluentBit resource with both labels and annotations

Expected behavior

Consistent behaviour for both of the options. Perhaps annotations should as well set the annotations on both the Daemonset and pods

Your Environment

- Fluent Operator version:
- Container Runtime:
- Operating system:
- Kernel version:

How did you install fluent operator?

No response

Additional context

Maybe append fb.Annotations and fb.Spec.Annotations and then set?
https://github.com/fluent/fluent-operator/blob/master/pkg/operator/daemonset.go#L36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant