fix(query): leave coordinates array as-is in geo queries #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zertz
force-pushed
the
fix-issue-187
branch
2 times, most recently
from
b5f3978 to
3cd645a
Compare
|
@florianholzapfel Can you have a quick look? There is an edge case where it is breaking and that is if a user has a field named |
florianholzapfel
added a commit
that referenced
this pull request
Mar 15, 2016
fix(query): leave coordinates array as-is in geo queries
|
yes, this seems very unlikely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to guess if a value being
JSON.parse'd is likely to be a coordinate. The key must becoordinatesand the value must be an array of two numbers.However, I'm not sure if it may cause issues in some cases.
Closes #187