Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cufinufft) alloca might cause a slow down #570

Open
DiamonDinoia opened this issue Oct 4, 2024 · 1 comment
Open

(cufinufft) alloca might cause a slow down #570

DiamonDinoia opened this issue Oct 4, 2024 · 1 comment
Assignees

Comments

@DiamonDinoia
Copy link
Collaborator

DiamonDinoia commented Oct 4, 2024

While it did not show up in my tests, it seems that alloca might cause a slow down although it reduces VRAM usage.

One solution is to make alloca an option and generate kernels with and without alloca. To do so we need to move alloca from a define to a template parameter.

Details: mind-inria/mri-nufft-benchmark#5

@paquiteau @Lenoush

@ahbarnett
Copy link
Collaborator

Marco to benchmark GPU when enabling alloca --- add a opts.gpu_* for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants