Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose removing old unmaintained skcuda code #1416

Open
kushalkolar opened this issue Oct 26, 2024 · 1 comment
Open

Propose removing old unmaintained skcuda code #1416

kushalkolar opened this issue Oct 26, 2024 · 1 comment

Comments

@kushalkolar
Copy link
Collaborator

kushalkolar commented Oct 26, 2024

Should probably remove all the cuda stuff from motion correction because it just confuses people, example: #1048 . skcuda is no longer maintained, last release was over 5 years ago, so it's very unlikely to work with any relatively recently CUDA version and GPU, and would be difficult to interface with any other software. Given these limitations I don't even have a way to test if this even works. If users want GPU accelerated NoRMCorre we should just redirect them to FIOLA or jnormcorre which do a great job.

if HAS_CUDA and use_cuda:
from skcuda.fft import Plan
from skcuda.fft import fft as cudafft
from skcuda.fft import ifft as cudaifft
try:
cudactx # type: ignore
except NameError:
init_cuda_process()

@pgunn
Copy link
Member

pgunn commented Oct 28, 2024

It's not entirely unmaintained; the author seems to occasionally still be accepting patches, but no release in nine years isn't great.

I think this proposal seems reasonable; the other option would be to port it to some other framework (which would at least not require people to go out-of-codebase) but I'm not keen to volunteer for such work; unless someone else shows up keen to do that soon, removing these codepaths is probably a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants