cgroupv1: abort the update if Flatcar version does not support it #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ader1990
force-pushed
the
ader1990/cgroupv1-no-upgrade
branch
2 times, most recently
from
d13ccd0
to
e0fb3ab
Compare
2 tasks
jepio
reviewed
Oct 24, 2024
flatcar-postinst
Outdated
| # Systemd version >= 256 does not boot anymore if cgroupv1 is enabled or SYSTEMD_CGROUP_ENABLE_LEGACY_FORCE=1 is set | ||
| # See: https://github.com/systemd/systemd/releases/tag/v256-rc3 | ||
| MAX_NEXT_VERSION_ID=5000 | ||
| if [ "${NEXT_VERSION_ID%%.*}" -ge $MAX_NEXT_VERSION_ID && ! -f "/sys/fs/cgroup/cgroup.controllers" ]; then |
There was a problem hiding this comment.
i think we don't need a version check here. We can ensure that any Flatcar version that has an update-engine that contains this change is merged together with the systemd-256 update.
am i wrong about this?
There was a problem hiding this comment.
Removed the check, but left the version number that will be changed accordingly so the user gets the release information.
ader1990
force-pushed
the
ader1990/cgroupv1-no-upgrade
branch
from
e0fb3ab
to
626d4b7
Compare
ader1990
force-pushed
the
ader1990/cgroupv1-no-upgrade
branch
from
626d4b7
to
df41db0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cgroupv1: abort the update if Flatcar version does not support it
See: flatcar/scripts#2145
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.