playbooks controller error when saving

[adityathebe]

mission-control/db/playbooks.go:202 ERROR: duplicate key value violates unique constraint "playbook_name_key" (SQLSTATE 23505)

This happens if a playbook CRD is deleted and reapplied. The old playbook still has a record in db and when the CRD is applied again it gets a new id but then runs into the unique name constraint violation.

This is the case with Connections controller as well.

Should be handled like how we're handling it in the topology controller.

[adityathebe]

@moshloop The way canary-checker is handling this, which I initially thought would be the correct approach, is also incorrect. If a topology (name: cluster) is deleted and then later someone applies another topology with the same name, we just update the original cluster topology spec and then undelete it. Which is wrong as the newly applied topology will have all sort of relationships to other tables (jobhistory, checks, ...).

I think changing the unique constraint to active records might be the solution we're looking for.

wdyt?